You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2024/11/08 16:25:49 UTC
[PR] perf: Prevent redundant calls to getRelevantDataMask [superset]
kgabryje opened a new pull request, #30883:
URL: https://github.com/apache/superset/pull/30883
### SUMMARY
Move `getRelevantDataMask` and `getAllActiveFilters` calls from Dashboard's `mapStateToProps` to a selector.
On a very large dashboard (300+ charts, 40+ filters) those calls delayed the dashboard loading time by over 3 seconds. After this change, they are negligible.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before - you can see that there's a 3.2s load event task, which really consists of thousands of `getRelevantDataMask` calls:
After - 0.8ms:
<img width="518" alt="image" src="https://github.com/user-attachments/assets/c609f3ec-e615-4012-84e6-e183ed0e7093">
### TESTING INSTRUCTIONS
Dashboards with native filters should work just like before
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] perf: Prevent redundant calls to getRelevantDataMask [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #30883:
URL: https://github.com/apache/superset/pull/30883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org