You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zddr (via GitHub)" <gi...@apache.org> on 2024/09/23 06:56:25 UTC

[PR] [case](mtmv)Failed to fix the case of concurrent insert overwrite execution [doris]

zddr opened a new pull request, #41125:
URL: https://github.com/apache/doris/pull/41125

   after： https://github.com/apache/doris/pull/40558 insert overwrite is not allowed in the same table
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [case](mtmv)Failed to fix the case of concurrent insert overwrite execution [doris]

Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #41125:
URL: https://github.com/apache/doris/pull/41125#issuecomment-2367515036

   run external


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [case](mtmv)Failed to fix the case of concurrent insert overwrite execution [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41125:
URL: https://github.com/apache/doris/pull/41125#issuecomment-2367365502

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [case](mtmv)Failed to fix the case of concurrent insert overwrite execution [doris]

Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #41125:
URL: https://github.com/apache/doris/pull/41125#issuecomment-2367365684

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [case](mtmv)Failed to fix the case of concurrent insert overwrite execution [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41125:
URL: https://github.com/apache/doris/pull/41125#issuecomment-2367400033

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [case](mtmv)Failed to fix the case of concurrent insert overwrite execution [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41125:
URL: https://github.com/apache/doris/pull/41125#issuecomment-2367400103

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [case](mtmv)Failed to fix the case of concurrent insert overwrite execution [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #41125:
URL: https://github.com/apache/doris/pull/41125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [case](mtmv)Failed to fix the case of concurrent insert overwrite execution [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #41125:
URL: https://github.com/apache/doris/pull/41125#discussion_r1771654136


##########
regression-test/suites/insert_overwrite_p1/test_iot_auto_detect_concurrent.groovy:
##########
@@ -98,10 +100,14 @@ suite("test_iot_auto_detect_concurrent") {
     thread6.join()
     thread7.join()
     // suppose result: Success to overwrite with a multiple of ten values
-    assertTrue(success_status)
-    qt_sql3 " select count(k0) from test_concurrent_write; "
-    qt_sql4 " select count(distinct k0) from test_concurrent_write; "
-
+    if (!success_status) {
+        // Not allowed running Insert Overwrite on same table
+        assertTrue(err_msg.contains('same table'))

Review Comment:
   if hit this branch, the output will miss `sql3` and `sql4`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org