You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Sai Boorlagadda <sb...@pivotal.io> on 2016/04/05 21:10:47 UTC
Review Request 45765: Fixed Javadocs for CacheFactory.create and
ClientCacheFactory.create
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45765/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Bugs: GEODE-564
https://issues.apache.org/jira/browse/GEODE-564
Repository: geode
Description
-------
Fixed Javadocs for CacheFactory.create and ClientCacheFactory.create
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/CacheFactory.java bcb9f130f75dd84a0b97a824fc7bd1f51cd3e9d5
geode-core/src/main/java/com/gemstone/gemfire/cache/client/ClientCacheFactory.java 99e11a0e8f041f3e9c2784b2014ff97fb072304e
Diff: https://reviews.apache.org/r/45765/diff/
Testing
-------
Thanks,
Sai Boorlagadda
Re: Review Request 45765: Fixed Javadocs for CacheFactory.create and
ClientCacheFactory.create
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45765/#review127242
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On April 5, 2016, 4:05 p.m., Sai Boorlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45765/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 4:05 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Bugs: GEODE-564
> https://issues.apache.org/jira/browse/GEODE-564
>
>
> Repository: geode
>
>
> Description
> -------
>
> Fixed Javadocs for CacheFactory.create and ClientCacheFactory.create
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/CacheFactory.java bcb9f130f75dd84a0b97a824fc7bd1f51cd3e9d5
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/ClientCacheFactory.java 99e11a0e8f041f3e9c2784b2014ff97fb072304e
>
> Diff: https://reviews.apache.org/r/45765/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sai Boorlagadda
>
>
Re: Review Request 45765: Fixed Javadocs for CacheFactory.create and
ClientCacheFactory.create
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45765/
-----------------------------------------------------------
(Updated April 5, 2016, 11:05 p.m.)
Review request for geode and Darrel Schneider.
Bugs: GEODE-564
https://issues.apache.org/jira/browse/GEODE-564
Repository: geode
Description
-------
Fixed Javadocs for CacheFactory.create and ClientCacheFactory.create
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/CacheFactory.java bcb9f130f75dd84a0b97a824fc7bd1f51cd3e9d5
geode-core/src/main/java/com/gemstone/gemfire/cache/client/ClientCacheFactory.java 99e11a0e8f041f3e9c2784b2014ff97fb072304e
Diff: https://reviews.apache.org/r/45765/diff/
Testing
-------
Thanks,
Sai Boorlagadda
Re: Review Request 45765: Fixed Javadocs for CacheFactory.create and
ClientCacheFactory.create
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45765/#review127227
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/cache/CacheFactory.java (line 207)
<https://reviews.apache.org/r/45765/#comment190403>
What about IllegalStateException on this method?
It looks to me like it will throw it if the cache already exists and is not compatible.
It calls com.gemstone.gemfire.internal.cache.CacheConfig.validateCacheConfig(GemFireCacheImpl)
which throws IllegalStateException 5 places.
But it is always this message: "Existing cache has different cache configuration, it has:"
- Darrel Schneider
On April 5, 2016, 12:10 p.m., Sai Boorlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45765/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 12:10 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Bugs: GEODE-564
> https://issues.apache.org/jira/browse/GEODE-564
>
>
> Repository: geode
>
>
> Description
> -------
>
> Fixed Javadocs for CacheFactory.create and ClientCacheFactory.create
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/CacheFactory.java bcb9f130f75dd84a0b97a824fc7bd1f51cd3e9d5
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/ClientCacheFactory.java 99e11a0e8f041f3e9c2784b2014ff97fb072304e
>
> Diff: https://reviews.apache.org/r/45765/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sai Boorlagadda
>
>