You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/20 18:47:30 UTC

[GitHub] [incubator-nuttx] daniel-p-carvalho commented on a change in pull request #2049: Added support for resolution configuration. Added option to start or not the conversion when opening ADC device.

daniel-p-carvalho commented on a change in pull request #2049:
URL: https://github.com/apache/incubator-nuttx/pull/2049#discussion_r508761483



##########
File path: arch/arm/src/stm32l4/stm32l4_adc.c
##########
@@ -1291,10 +1331,11 @@ static int adc_setup(FAR struct adc_dev_s *dev)
   adc_putreg(priv, STM32L4_ADC_SMPR1_OFFSET, ADC_SMPR1_DEFAULT);
   adc_putreg(priv, STM32L4_ADC_SMPR2_OFFSET, ADC_SMPR2_DEFAULT);
 
+  #ifdef HAVE_ADC_RESOLUTION

Review comment:
       @ghn-certi Which line are you talking about? Are you referring to the coding standard?
   
   Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org