You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2021/01/29 05:10:26 UTC
[pulsar] branch master updated: Expose more info with unknown
exception (#9323)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 4896192 Expose more info with unknown exception (#9323)
4896192 is described below
commit 4896192be81c6b1e2c67ec4ad7cf12736746cf1b
Author: Renkai Ge <ga...@gmail.com>
AuthorDate: Fri Jan 29 13:10:00 2021 +0800
Expose more info with unknown exception (#9323)
* Expose more info with unknown exception
Signed-off-by: Renkai <ga...@gmail.com>
* polish
Signed-off-by: Renkai <ga...@gmail.com>
* polish
Signed-off-by: Renkai <ga...@gmail.com>
* drop {} to enable detail exception
Signed-off-by: Renkai <ga...@gmail.com>
---
.../java/org/apache/bookkeeper/mledger/ManagedLedgerException.java | 6 +++++-
.../java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java | 2 +-
.../main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java | 6 ++----
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerException.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerException.java
index 0f56b99..31e0723 100644
--- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerException.java
+++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerException.java
@@ -23,7 +23,7 @@ import org.apache.bookkeeper.common.annotation.InterfaceStability;
@InterfaceAudience.LimitedPrivate
@InterfaceStability.Stable
-@SuppressWarnings({"serial", "checkstyle:javadoctype"})
+@SuppressWarnings({ "serial", "checkstyle:javadoctype" })
public class ManagedLedgerException extends Exception {
public ManagedLedgerException(String msg) {
super(msg);
@@ -33,6 +33,10 @@ public class ManagedLedgerException extends Exception {
super(e);
}
+ public ManagedLedgerException(String msg, Throwable e) {
+ super(msg, e);
+ }
+
public static ManagedLedgerException getManagedLedgerException(Throwable e) {
if (e instanceof ManagedLedgerException) {
return (ManagedLedgerException) e;
diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
index 09d7520..a36b1c4 100644
--- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
+++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
@@ -3436,7 +3436,7 @@ public class ManagedLedgerImpl implements ManagedLedger, CreateCallback {
return createManagedLedgerException(t.getCause());
} else {
log.error("Unknown exception for ManagedLedgerException.", t);
- return new ManagedLedgerException("Unknown exception");
+ return new ManagedLedgerException("Other exception", t);
}
}
diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java
index 4b26ba9..91a6e26 100644
--- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java
+++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java
@@ -19,12 +19,10 @@
package org.apache.bookkeeper.mledger.impl;
import static org.apache.bookkeeper.mledger.util.SafeRun.safeRun;
-
import com.google.common.collect.Lists;
import io.netty.util.Recycler;
import io.netty.util.Recycler.Handle;
import java.util.List;
-
import org.apache.bookkeeper.mledger.AsyncCallbacks.ReadEntriesCallback;
import org.apache.bookkeeper.mledger.Entry;
import org.apache.bookkeeper.mledger.ManagedLedgerException;
@@ -115,8 +113,8 @@ class OpReadEntry implements ReadEntriesCallback {
checkReadCompletion();
} else {
if (!(exception instanceof TooManyRequestsException)) {
- log.warn("[{}][{}] read failed from ledger at position:{} : {}", cursor.ledger.getName(),
- cursor.getName(), readPosition, exception.getMessage());
+ log.warn("[{}][{}] read failed from ledger at position:{}", cursor.ledger.getName(),
+ cursor.getName(), readPosition, exception);
} else {
if (log.isDebugEnabled()) {
log.debug("[{}][{}] read throttled failed from ledger at position:{}", cursor.ledger.getName(),