You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/26 05:05:23 UTC

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on a change in pull request #4567: [Fix-4566][worker] worker-server logback partial logs are not printed

zhuangchong commented on a change in pull request #4567:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4567#discussion_r564218218



##########
File path: dolphinscheduler-server/src/main/resources/logback-worker.xml
##########
@@ -56,10 +56,6 @@
     </appender>
     <appender name="WORKERLOGFILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
         <file>${log.base}/dolphinscheduler-worker.log</file>
-        <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
-            <level>INFO</level>
-        </filter>
-        <filter class="org.apache.dolphinscheduler.server.log.WorkerLogFilter"/>

Review comment:
       1.ThresholdFilter configuration and root level configuration are INFO, so remove the ThresholdFilter configuration
   2.the log in TaskKillProcessor.process method does not exist in the worker.log file, because of the WorkerLogFilter




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org