Re: [C2.1-dev] [PATCH] Major changes in Source interface and others

[Ovidiu Predescu <ov...@cup.hp.com>]

Thanks, Giacomo!

I checked and I didn't see the ModifiableSource.java in the
repository. Did you add the file to the repository?

Thanks,
Ovidiu

On Sat, 25 Aug 2001 21:47:50 +0200 (CEST), giacomo <gi...@apache.org> wrote:

> On Fri, 24 Aug 2001, Ovidiu Predescu wrote:
> 
> Ovidiou
> 
> I've applied your patch. Please cross check.
> 
> Thanks,
> Giacomo
> 
> > Hi,
> >
> > I now have a working version of the changes to the Source interface. They are
> > based on the latest changes Sylvain made to XMLFragment.
> >
> > I've tested everything I could, I haven't noticed any regression. All the
> > failures that appear are also in the today's main trunk as well, so unless I
> > missed something don't blame me for them ;-)
> >
> > The changes are a little bit different from what Carsten and I discussed.
> > During the refactoring I discovered it was quite difficult to make use of the
> > FileSource interface, so I left it out for the moment. We can add such an
> > interface after the patch is applied and we have a clear idea of how to fit it
> > in.
> >
> > Because the changes are so substantial, please don't commit anything else
> > before you commit this patch. I generated against the latest sources I got from
> > the main trunk today at 5pm.
> >
> > Greetings,
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org

Re: [C2.1-dev] [PATCH] Major changes in Source interface and others

[giacomo <gi...@apache.org>]

On Sat, 25 Aug 2001, Ovidiu Predescu wrote:

> Thanks, Giacomo!
>
> I checked and I didn't see the ModifiableSource.java in the
> repository. Did you add the file to the repository?

Oops, yes, forgot to add it. Done :)

Giacomo

>
> Thanks,
> Ovidiu
>
> On Sat, 25 Aug 2001 21:47:50 +0200 (CEST), giacomo <gi...@apache.org> wrote:
>
> > On Fri, 24 Aug 2001, Ovidiu Predescu wrote:
> >
> > Ovidiou
> >
> > I've applied your patch. Please cross check.
> >
> > Thanks,
> > Giacomo
> >
> > > Hi,
> > >
> > > I now have a working version of the changes to the Source interface. They are
> > > based on the latest changes Sylvain made to XMLFragment.
> > >
> > > I've tested everything I could, I haven't noticed any regression. All the
> > > failures that appear are also in the today's main trunk as well, so unless I
> > > missed something don't blame me for them ;-)
> > >
> > > The changes are a little bit different from what Carsten and I discussed.
> > > During the refactoring I discovered it was quite difficult to make use of the
> > > FileSource interface, so I left it out for the moment. We can add such an
> > > interface after the patch is applied and we have a clear idea of how to fit it
> > > in.
> > >
> > > Because the changes are so substantial, please don't commit anything else
> > > before you commit this patch. I generated against the latest sources I got from
> > > the main trunk today at 5pm.
> > >
> > > Greetings,
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
> >
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org