You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/04/03 04:34:35 UTC

[GitHub] zeppelin pull request #2214: [MINOR] remove typo in line and area chart

GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2214

    [MINOR] remove typo in line and area chart

    ### What is this PR for?
    The line and area chart have the typos `xLables`, not `xLabels`.
    However, this line is not necessary, because `xLabels` is defined by `render` function. That's why these chart was working well.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * None
    
    ### How should this be tested?
    - Run line and area chart and check whether it works well or not.
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPLIN_remove_initial_code_in_Chart

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2214
    
----
commit c4ec2eef2cc0eb29a0e8f3e86288ce5b4bdefd00
Author: soralee <so...@zepl.com>
Date:   2017-04-03T04:09:10Z

    remove initial code in chart

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2214: [MINOR] remove typo in line and area chart

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2214
  
    LGTM and merge to master and branch-0.7!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2214: [MINOR] remove typo in line and area chart

Posted by soralee <gi...@git.apache.org>.

Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2214
  
    Thanks @Leemoonsoo @felixcheung 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2214: [MINOR] remove typo in line and area chart

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2214


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---