You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2023/01/20 04:19:25 UTC
[GitHub] [gobblin] codecov-commenter commented on pull request #3627: Specifically name each Hikari connection pool created, for traceability
codecov-commenter commented on PR #3627:
URL: https://github.com/apache/gobblin/pull/3627#issuecomment-1397906097
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3627](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b377106) into [master](https://codecov.io/gh/apache/gobblin/commit/85cd1f9875ba64bd059b70a4d5fc40a38383d326?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85cd1f9) will **decrease** coverage by `2.64%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## master #3627 +/- ##
============================================
- Coverage 46.44% 43.81% -2.64%
+ Complexity 10621 2063 -8558
============================================
Files 2130 409 -1721
Lines 83303 17639 -65664
Branches 9282 2152 -7130
============================================
- Hits 38692 7728 -30964
+ Misses 41039 9053 -31986
+ Partials 3572 858 -2714
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/gobblin/util/jdbc/DataSourceProvider.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvamRiYy9EYXRhU291cmNlUHJvdmlkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `10.54% <80.00%> (+2.44%)` | :arrow_up: |
| [...obblin/metastore/JobHistoryDataSourceProvider.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0pvYkhpc3RvcnlEYXRhU291cmNlUHJvdmlkZXIuamF2YQ==) | `66.66% <100.00%> (+4.16%)` | :arrow_up: |
| [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | | |
| [...a/org/apache/gobblin/source/jdbc/JdbcProvider.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL0pkYmNQcm92aWRlci5qYXZh) | | |
| [...ervice/modules/db/ServiceDatabaseProviderImpl.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYi9TZXJ2aWNlRGF0YWJhc2VQcm92aWRlckltcGwuamF2YQ==) | | |
| [...in/java/org/apache/gobblin/r2/R2ClientFactory.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9yMi9SMkNsaWVudEZhY3RvcnkuamF2YQ==) | | |
| [...ompaction/mapreduce/RecordKeyDedupReducerBase.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL1JlY29yZEtleURlZHVwUmVkdWNlckJhc2UuamF2YQ==) | | |
| [...management/partition/CopyableDatasetRequestor.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3BhcnRpdGlvbi9Db3B5YWJsZURhdGFzZXRSZXF1ZXN0b3IuamF2YQ==) | | |
| [.../extractor/hadoop/OldApiWritableFileExtractor.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvaGFkb29wL09sZEFwaVdyaXRhYmxlRmlsZUV4dHJhY3Rvci5qYXZh) | | |
| ... and [1716 more](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org