You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/12/09 04:27:35 UTC
Review Request 54571: Timed health check duration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54571/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman and haosdent huang.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/health-check/health_checker.hpp 1230f963a98cd9a373d98cb6f67eb1b7e89c823d
src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
Diff: https://reviews.apache.org/r/54571/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 54571: Timed health check duration.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54571/#review158645
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54570, 54571]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 9, 2016, 4:27 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54571/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 4:27 a.m.)
>
>
> Review request for mesos, Gast�n Kleiman and haosdent huang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/health-check/health_checker.hpp 1230f963a98cd9a373d98cb6f67eb1b7e89c823d
> src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
>
> Diff: https://reviews.apache.org/r/54571/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 54571: Timed health check duration.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54571/#review158726
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54570, 54571]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 9, 2016, 4:23 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54571/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 4:23 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/health-check/health_checker.hpp 1230f963a98cd9a373d98cb6f67eb1b7e89c823d
> src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
>
> Diff: https://reviews.apache.org/r/54571/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 54571: Timed health check duration.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54571/#review158687
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Dec. 9, 2016, 4:23 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54571/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 4:23 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/health-check/health_checker.hpp 1230f963a98cd9a373d98cb6f67eb1b7e89c823d
> src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
>
> Diff: https://reviews.apache.org/r/54571/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 54571: Timed health check duration.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54571/
-----------------------------------------------------------
(Updated Dec. 9, 2016, 4:23 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/health-check/health_checker.hpp 1230f963a98cd9a373d98cb6f67eb1b7e89c823d
src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
Diff: https://reviews.apache.org/r/54571/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 54571: Timed health check duration.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54571/
-----------------------------------------------------------
(Updated Dec. 9, 2016, 4:19 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/health-check/health_checker.hpp 1230f963a98cd9a373d98cb6f67eb1b7e89c823d
src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
Diff: https://reviews.apache.org/r/54571/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 54571: Timed health check duration.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54571/
-----------------------------------------------------------
(Updated Dec. 9, 2016, 3:11 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/health-check/health_checker.hpp 1230f963a98cd9a373d98cb6f67eb1b7e89c823d
src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
Diff: https://reviews.apache.org/r/54571/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 54571: Timed health check duration.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54571/#review158642
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
src/health-check/health_checker.cpp (line 279)
<https://reviews.apache.org/r/54571/#comment229428>
Should it end with period?
```
// Restart the stopwatch.
```
- haosdent huang
On Dec. 9, 2016, 4:27 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54571/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 4:27 a.m.)
>
>
> Review request for mesos, Gast�n Kleiman and haosdent huang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/health-check/health_checker.hpp 1230f963a98cd9a373d98cb6f67eb1b7e89c823d
> src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
>
> Diff: https://reviews.apache.org/r/54571/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>