[jira] [Commented] (AIRFLOW-3753) Upgrade Google Oauth Backend from Flask Oauthlib to Authlib

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932243#comment-16932243 ] 

ASF GitHub Bot commented on AIRFLOW-3753:
-----------------------------------------

lepture commented on pull request #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3753
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Flask-OAuthlib is deprecated, use Authlib instead. Updated Google and GitHub Enterprise OAuth backends.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Upgrade Google Oauth Backend from Flask Oauthlib to Authlib
> -----------------------------------------------------------
>
>                 Key: AIRFLOW-3753
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3753
>             Project: Apache Airflow
>          Issue Type: Wish
>            Reporter: Daniel Rubenstein
>            Priority: Minor
>
> [Airflow's contributed backed for Google Authentication|https://github.com/apache/airflow/blob/master/airflow/contrib/auth/backends/google_auth.py] relies on the python library [Flask Oauthlib|https://github.com/lepture/flask-oauthlib], and is tied to having a version greater than 0.9.1 ([see setup.py|https://github.com/apache/airflow/blob/master/setup.py#L186]).
> As of March 2018 (see [this update|https://github.com/lepture/flask-oauthlib/commit/7a58b6d48a99a2d3aca4e887a4bb56458fcc6e46#diff-88b99bb28683bd5b7e3a204826ead112]), [Authlib|https://github.com/lepture/authlib] (maintained by the same owner) has been recommended as the replacement.
> Since that time, external changes to Oauth have caused various breaks in builds that are pinned to this version, as Flask-Oauthlib is deprecated at this point and does not receive standard PyPI updates and other maintenance.
> I'm wondering if the maintainers of the project would accept a PR that updates the backend to use the newer library. I'd be happy to take a crack at it, just want to make sure it's something that the community sees as worthwhile before getting started.
> Thanks!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)