[GitHub] [ozone] sadanand48 commented on a diff in pull request #4578: HDDS-8418. Lease Manager unsafe method fix

["sadanand48 (via GitHub)" <gi...@apache.org>]

sadanand48 commented on code in PR #4578:
URL: https://github.com/apache/ozone/pull/4578#discussion_r1327037193


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/events/EventWatcher.java:
##########
@@ -157,13 +146,14 @@ protected synchronized void handleCompletion(COMPLETION_PAYLOAD
     }
   }
 
-  private synchronized void handleTimeout(EventPublisher publisher,
+  private synchronized Void handleTimeout(EventPublisher publisher,

Review Comment:
   I didn't get this part, what is the impact of changing void-> Void and returning null



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org