You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/07/22 07:46:45 UTC
[GitHub] [servicecomb-java-chassis] hujinming178 opened a new pull request, #3212: [#3187]Automatic updating of contracts for third parties using Servic…
hujinming178 opened a new pull request, #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212
…ecomb (Spring-cloud-Huawei)
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] hujinming178 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
hujinming178 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r928495199
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/model/ServiceCenterConfiguration.java:
##########
@@ -26,12 +26,23 @@ public class ServiceCenterConfiguration {
*/
private Boolean ignoreSwaggerDifferent;
+ private Boolean rewriteSwagger;
+
public Boolean isIgnoreSwaggerDifferent() {
return ignoreSwaggerDifferent;
}
+ public Boolean canRewriteSwagger(){
+ return rewriteSwagger;
+ }
+
Review Comment:
The return value will be used later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r927396638
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/model/ServiceCenterConfiguration.java:
##########
@@ -26,12 +26,23 @@ public class ServiceCenterConfiguration {
*/
private Boolean ignoreSwaggerDifferent;
+ private Boolean rewriteSwagger;
+
public Boolean isIgnoreSwaggerDifferent() {
return ignoreSwaggerDifferent;
}
+ public Boolean canRewriteSwagger(){
+ return rewriteSwagger;
+ }
+
Review Comment:
generate getter/setter, do not write yourself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r927396375
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/model/ServiceCenterConfiguration.java:
##########
@@ -26,12 +26,23 @@ public class ServiceCenterConfiguration {
*/
private Boolean ignoreSwaggerDifferent;
+ private Boolean rewriteSwagger;
Review Comment:
change to boolean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r928617947
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterRegistration.java:
##########
@@ -131,12 +131,20 @@ public void execute() {
startTask(new RegisterSchemaTask(0));
} else {
Microservice newMicroservice = serviceCenterClient.getMicroserviceByServiceId(serviceResponse.getServiceId());
- dealIsSwaggerDifferent(newMicroservice);
+ if (isSwaggerDifferent(newMicroservice)){
+ if (canRewriteSwagger()){
+ LOGGER.warn("Service has already registered, but schema ids not equal. However, it will continue to register");
+ startTask(new RegisterSchemaTask(0));
+ }else {
Review Comment:
format code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r927401136
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterRegistration.java:
##########
@@ -131,7 +131,14 @@ public void execute() {
startTask(new RegisterSchemaTask(0));
} else {
Microservice newMicroservice = serviceCenterClient.getMicroserviceByServiceId(serviceResponse.getServiceId());
- dealIsSwaggerDifferent(newMicroservice);
+ boolean swaggerDifferent = isSwaggerDifferent(newMicroservice);
Review Comment:
`if (isSwaggerDifferent(newMicroservice))` use this to avoid many temporary variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r928622127
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/model/ServiceCenterConfiguration.java:
##########
@@ -24,14 +24,25 @@ public class ServiceCenterConfiguration {
* when swagger is different between local with remote serviceCenter. if ignoreSwaggerDifferent is true.
* it will ignore the different and continue the program. otherwise, the program will be stop.
*/
- private Boolean ignoreSwaggerDifferent;
+ private boolean ignoreSwaggerDifferent;
- public Boolean isIgnoreSwaggerDifferent() {
+ private boolean rewriteSwagger;
+
+ public boolean isIgnoreSwaggerDifferent() {
return ignoreSwaggerDifferent;
}
- public ServiceCenterConfiguration setIgnoreSwaggerDifferent(Boolean ignoreSwaggerDifferent) {
+ public boolean canRewriteSwagger(){
Review Comment:
isCanOverwriteSwagger, using IDE getter/setter generator to add getter/setters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r929785906
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterRegistration.java:
##########
@@ -149,17 +160,8 @@ public void execute() {
}
}
- private void dealIsSwaggerDifferent(Microservice newMicroservice) {
- if (isListEquals(newMicroservice.getSchemas(), microservice.getSchemas())) {
- return;
- }
- if (!serviceCenterConfiguration.isIgnoreSwaggerDifferent()) {
- throw new IllegalStateException("Service has already registered, but schema ids not equal, stop register. "
- + "Change the microservice version or delete the old microservice info and try again.");
- }
- LOGGER.warn("Service has already registered, but schema ids not equal. However, it will continue to register. "
- + "If you want to eliminate this warning. you can Change the microservice version or delete the old " +
- "microservice info and try again. eg: version:1.0.0 -> 1.0.1");
+ private boolean isSwaggerDifferent(Microservice newMicroservice) {
+ return !isListEquals(newMicroservice.getSchemas(),microservice.getSchemas());
Review Comment:
format code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r929783057
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/model/ServiceCenterConfiguration.java:
##########
@@ -24,14 +24,25 @@ public class ServiceCenterConfiguration {
* when swagger is different between local with remote serviceCenter. if ignoreSwaggerDifferent is true.
* it will ignore the different and continue the program. otherwise, the program will be stop.
*/
- private Boolean ignoreSwaggerDifferent;
+ private boolean ignoreSwaggerDifferent;
- public Boolean isIgnoreSwaggerDifferent() {
+ private boolean canOverwriteSwagger;
Review Comment:
default value to true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r928612720
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterRegistration.java:
##########
@@ -131,12 +131,20 @@ public void execute() {
startTask(new RegisterSchemaTask(0));
} else {
Microservice newMicroservice = serviceCenterClient.getMicroserviceByServiceId(serviceResponse.getServiceId());
- dealIsSwaggerDifferent(newMicroservice);
+ if (isSwaggerDifferent(newMicroservice)){
+ if (canRewriteSwagger()){
+ LOGGER.warn("Service has already registered, but schema ids not equal. However, it will continue to register");
Review Comment:
Service has already registered, but schema ids not equal, try to register it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r929780255
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterRegistration.java:
##########
@@ -131,12 +131,23 @@ public void execute() {
startTask(new RegisterSchemaTask(0));
} else {
Microservice newMicroservice = serviceCenterClient.getMicroserviceByServiceId(serviceResponse.getServiceId());
- dealIsSwaggerDifferent(newMicroservice);
microservice.setServiceId(serviceResponse.getServiceId());
microserviceInstance.setServiceId(serviceResponse.getServiceId());
microserviceInstance.setMicroservice(microservice);
+ if (isSwaggerDifferent(newMicroservice)) {
+ if (serviceCenterConfiguration.isCanOverwriteSwagger()) {
+ LOGGER.warn("Service has already registered, but schema ids not equal, try to register it again");
+ startTask(new RegisterSchemaTask(0));
+ return;
+ }
+ if (serviceCenterConfiguration.isIgnoreSwaggerDifferent()) {
+ LOGGER.warn("Service has already registered, but schema ids not equal, try to register it again");
Review Comment:
This log message is not correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r927400448
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterRegistration.java:
##########
@@ -149,17 +156,29 @@ public void execute() {
}
}
- private void dealIsSwaggerDifferent(Microservice newMicroservice) {
- if (isListEquals(newMicroservice.getSchemas(), microservice.getSchemas())) {
- return;
+ private boolean isSwaggerDifferent(Microservice newMicroservice) {
+ if (!isListEquals(newMicroservice.getSchemas(),microservice.getSchemas())){
+ if (!serviceCenterConfiguration.isIgnoreSwaggerDifferent()){
+ return true;
+ }else {
+ LOGGER.warn("Service has already registered, but schema ids not equal. However, it will continue to register. "
+ + "If you want to eliminate this warning. you can Change the microservice version or delete the old " +
+ "microservice info and try again. eg: version:1.0.0 -> 1.0.1");
+ return false;
+ }
}
- if (!serviceCenterConfiguration.isIgnoreSwaggerDifferent()) {
- throw new IllegalStateException("Service has already registered, but schema ids not equal, stop register. "
- + "Change the microservice version or delete the old microservice info and try again.");
+ return false;
+ }
+
+ private boolean canRewriteSwagger(){
+ if (serviceCenterConfiguration.canRewriteSwagger()){
+ return true;
+ }else {
+ LOGGER.warn("Service has already registered, but schema ids not equal. However, it will continue to register. "
+ + "If you want to eliminate this warning. you can Change the microservice version or delete the old " +
+ "microservice info and try again. eg: version:1.0.0 -> 1.0.1");
}
- LOGGER.warn("Service has already registered, but schema ids not equal. However, it will continue to register. "
- + "If you want to eliminate this warning. you can Change the microservice version or delete the old " +
- "microservice info and try again. eg: version:1.0.0 -> 1.0.1");
+ return false;
Review Comment:
method return boolean do not write logs. find a property way to reorganize code
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterRegistration.java:
##########
@@ -149,17 +156,29 @@ public void execute() {
}
}
- private void dealIsSwaggerDifferent(Microservice newMicroservice) {
- if (isListEquals(newMicroservice.getSchemas(), microservice.getSchemas())) {
- return;
+ private boolean isSwaggerDifferent(Microservice newMicroservice) {
+ if (!isListEquals(newMicroservice.getSchemas(),microservice.getSchemas())){
+ if (!serviceCenterConfiguration.isIgnoreSwaggerDifferent()){
+ return true;
Review Comment:
method return boolean do not write logs. find a property way to reorganize code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r928617513
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterRegistration.java:
##########
@@ -149,17 +157,15 @@ public void execute() {
}
}
- private void dealIsSwaggerDifferent(Microservice newMicroservice) {
- if (isListEquals(newMicroservice.getSchemas(), microservice.getSchemas())) {
- return;
- }
- if (!serviceCenterConfiguration.isIgnoreSwaggerDifferent()) {
- throw new IllegalStateException("Service has already registered, but schema ids not equal, stop register. "
- + "Change the microservice version or delete the old microservice info and try again.");
+ private boolean isSwaggerDifferent(Microservice newMicroservice) {
+ if (!isListEquals(newMicroservice.getSchemas(),microservice.getSchemas())) {
+ return !serviceCenterConfiguration.isIgnoreSwaggerDifferent();
}
- LOGGER.warn("Service has already registered, but schema ids not equal. However, it will continue to register. "
- + "If you want to eliminate this warning. you can Change the microservice version or delete the old " +
- "microservice info and try again. eg: version:1.0.0 -> 1.0.1");
+ return false;
+ }
Review Comment:
Maybe only has `isListEquals`, check `isIgnoreSwaggerDifferent` after `canRewriteSwagger`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r928615349
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterRegistration.java:
##########
@@ -131,12 +131,20 @@ public void execute() {
startTask(new RegisterSchemaTask(0));
} else {
Microservice newMicroservice = serviceCenterClient.getMicroserviceByServiceId(serviceResponse.getServiceId());
- dealIsSwaggerDifferent(newMicroservice);
+ if (isSwaggerDifferent(newMicroservice)){
+ if (canRewriteSwagger()){
+ LOGGER.warn("Service has already registered, but schema ids not equal. However, it will continue to register");
+ startTask(new RegisterSchemaTask(0));
+ }else {
+ LOGGER.warn("Service has already registered, but schema ids not equal. However, it will continue to register. "
+ + "If you want to eliminate this warning. you can Change the microservice version or delete the old " +
+ "microservice info and try again. eg: version:1.0.0 -> 1.0.1");
Review Comment:
Seem wrong, else should
```
throw new IllegalStateException("Service has already registered, but schema ids not equal, stop register. "
+ "Change the microservice version or delete the old microservice info and try again.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r928621606
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/model/ServiceCenterConfiguration.java:
##########
@@ -24,14 +24,25 @@ public class ServiceCenterConfiguration {
* when swagger is different between local with remote serviceCenter. if ignoreSwaggerDifferent is true.
* it will ignore the different and continue the program. otherwise, the program will be stop.
*/
- private Boolean ignoreSwaggerDifferent;
+ private boolean ignoreSwaggerDifferent;
- public Boolean isIgnoreSwaggerDifferent() {
+ private boolean rewriteSwagger;
Review Comment:
canOverwriteSwagger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3212: [#3187]Automatic updating of contracts for third parties using Servic…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3212:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3212#discussion_r928613668
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterRegistration.java:
##########
@@ -131,12 +131,20 @@ public void execute() {
startTask(new RegisterSchemaTask(0));
} else {
Microservice newMicroservice = serviceCenterClient.getMicroserviceByServiceId(serviceResponse.getServiceId());
- dealIsSwaggerDifferent(newMicroservice);
+ if (isSwaggerDifferent(newMicroservice)){
+ if (canRewriteSwagger()){
+ LOGGER.warn("Service has already registered, but schema ids not equal. However, it will continue to register");
+ startTask(new RegisterSchemaTask(0));
+ }else {
+ LOGGER.warn("Service has already registered, but schema ids not equal. However, it will continue to register. "
+ + "If you want to eliminate this warning. you can Change the microservice version or delete the old " +
+ "microservice info and try again. eg: version:1.0.0 -> 1.0.1");
Review Comment:
Service has already registered, but schema ids not equal. Ignore and continue to register.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org