You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/15 09:40:44 UTC

[GitHub] [iotdb] HTHou commented on a diff in pull request #6998: [IOTDB-4121] logical optimizations for ImportCsv

HTHou commented on code in PR #6998:
URL: https://github.com/apache/iotdb/pull/6998#discussion_r945570604


##########
cli/src/main/java/org/apache/iotdb/tool/ImportCsv.java:
##########
@@ -829,7 +833,7 @@ private static Object typeTrans(String value, TSDataType type) {
           if (value.startsWith("\"") && value.endsWith("\"")) {
             return value.substring(1, value.length() - 1);
           }
-          return null;
+          return value;

Review Comment:
   Update the user guides in https://github.com/apache/iotdb/blob/master/docs/UserGuide/Write-And-Delete-Data/CSV-Tool.md and https://github.com/apache/iotdb/blob/master/docs/zh/UserGuide/Write-And-Delete-Data/CSV-Tool.md .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org