You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2018/03/20 00:06:07 UTC
Re: Review Request 53267: Added log and counter for tracking
subscribers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/
-----------------------------------------------------------
(Updated March 19, 2018, 5:06 p.m.)
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
Bugs: MESOS-6499
https://issues.apache.org/jira/browse/MESOS-6499
Repository: mesos
Description
-------
Added log and counter for tracking subscribers.
Diffs
-----
src/master/master.hpp 87186c6e733a686f96528b1722fda1c287e9c881
src/master/master.cpp 23ddb995b4ad0fcdb589974308a2e81ececdad31
src/master/metrics.hpp 056d290c1e14a6afd5056873ef7bb07b5892ed32
src/master/metrics.cpp 1f049f3794c1bca45d2684cbbec3b08c1a78c494
Diff: https://reviews.apache.org/r/53267/diff/1/
Testing
-------
Ran this on master with a client keeps subscribing and disconnecting. Observes that gauge gets updated and new log line is printed.
Thanks,
Zhitao Li
Re: Review Request 53267: Added log and counter for tracking
subscribers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/#review199507
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 53267`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/53267
Relevant logs:
- [apply-review-53267-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/53267/logs/apply-review-53267-stdout.log):
```
error: patch failed: src/master/master.hpp:1896
error: src/master/master.hpp: patch does not apply
error: patch failed: src/master/master.cpp:8335
error: src/master/master.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On March 20, 2018, 12:06 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53267/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 12:06 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
>
>
> Bugs: MESOS-6499
> https://issues.apache.org/jira/browse/MESOS-6499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added log and counter for tracking subscribers.
>
>
> Diffs
> -----
>
> src/master/master.hpp 87186c6e733a686f96528b1722fda1c287e9c881
> src/master/master.cpp 23ddb995b4ad0fcdb589974308a2e81ececdad31
> src/master/metrics.hpp 056d290c1e14a6afd5056873ef7bb07b5892ed32
> src/master/metrics.cpp 1f049f3794c1bca45d2684cbbec3b08c1a78c494
>
>
> Diff: https://reviews.apache.org/r/53267/diff/1/
>
>
> Testing
> -------
>
> Ran this on master with a client keeps subscribing and disconnecting. Observes that gauge gets updated and new log line is printed.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 53267: Added a gauge to track active subscribers.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/
-----------------------------------------------------------
(Updated April 12, 2018, 2:32 p.m.)
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
Changes
-------
Rebase and updated summary.
Summary (updated)
-----------------
Added a gauge to track active subscribers.
Bugs: MESOS-6499
https://issues.apache.org/jira/browse/MESOS-6499
Repository: mesos
Description (updated)
-------
Added a gauge to track active subscribers.
Diffs (updated)
-----
src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828
src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2
src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb
Diff: https://reviews.apache.org/r/53267/diff/2/
Changes: https://reviews.apache.org/r/53267/diff/1-2/
Testing
-------
Ran this on master with a client keeps subscribing and disconnecting. Observes that gauge gets updated and new log line is printed.
Thanks,
Zhitao Li