You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by Sheng Wu <wu...@gmail.com> on 2020/03/16 07:25:56 UTC
[ACTION REQUIRE] SkyWalking 7.0.0 Release Test
Hi Dev team
In the last 2 months, we focus on the new SkyWalking 7.0.0, now all
features have been provided.
We should begin to tests, give feedback about whether it is ready to
release and only accept PR about the bug fix.
After the tests, I will begin the official release of 7.0.0.
Sheng Wu 吴晟
Twitter, wusheng1108
Re: [ACTION REQUIRE] SkyWalking 7.0.0 Release Test
Posted by Hongtao Gao <ha...@gmail.com>.
Hi all.
I just check out the building docker image and running container. They all
work well as I expect.
Thanks, Hongtao
Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:26写道：
> Hi Dev team
>
> In the last 2 months, we focus on the new SkyWalking 7.0.0, now all
> features have been provided.
> We should begin to tests, give feedback about whether it is ready to
> release and only accept PR about the bug fix.
>
> After the tests, I will begin the official release of 7.0.0.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
--
Hongtao Gao
Apache SkyWalking && Apache ShardingSphere
Twitter, @hanahmily
Re:[ACTION REQUIRE] SkyWalking 7.0.0 Release Test
Posted by kezhenxu94 <ke...@apache.org>.
Since I've been rewriting the E2E tests[1] recently and testing locally over and over,
with nothing wrong found, I'm good to do a release, here are the checked cases,
which you could also found on The GitHub Actions tab:
[v] storage plugins: including H2, MySQL, ES6, ES7, InfluxDB
[v] agent compatibilities with different JDK versions, including 8~12
[v] clustering oap with coordinator zookeeper
[v] profiling with different storages
all the checks above makes me confident that it's relatively stable and we could
do a release
[1] https://github.com/apache/skywalking/pull/4510
--
GitHub @kezhenxu94
Apache SkyWalking, Apache Dubbo
At 2020-03-16 15:25:56，"Sheng Wu" <wu...@gmail.com> wrote：
>Hi Dev team
>
>In the last 2 months, we focus on the new SkyWalking 7.0.0, now all
>features have been provided.
>We should begin to tests, give feedback about whether it is ready to
>release and only accept PR about the bug fix.
>
>After the tests, I will begin the official release of 7.0.0.
>
>Sheng Wu 吴晟
>Twitter, wusheng1108
Re: [ACTION REQUIRE] SkyWalking 7.0.0 Release Test
Posted by Sheng Wu <wu...@gmail.com>.
Finally, the UI tests passed. I am running the release process now.
For PHP, .net and nodejs agent dev team, still welcome to feedback.
Sheng Wu 吴晟
Twitter, wusheng1108
Sheng Wu <wu...@gmail.com> 于2020年3月18日周三 下午2:03写道：
> The UI of the profile has passed the test locally and on the demo env.
> But sadly, some profile UI related PRs override the old topology features.
>
> I have forwarded the issue to Yao Wang, we need to wait for that fix and
> test on the demo env again.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> han liu <mr...@gmail.com> 于2020年3月17日周二 下午11:22写道：
>
>> Hi
>>
>> We have fixed some problems in the profile function:
>> 1. PR[1]: Fix the analysis error in UI level, and increase the loading
>> effect during analysis.
>>
>> [1]: https://github.com/apache/skywalking/pull/4521
>>
>> Daming <zt...@foxmail.com> 于2020年3月17日周二 下午3:02写道：
>>
>> > Hi
>> > Here is a message about a bug fixed. I found a critical issue in
>> > InfluxDB-plugin. It will cause AlarmQuery error. Now, it is fixed in
>> PR[1].
>> >
>> > [1] https://github.com/apache/skywalking/pull/4529 <
>> > https://github.com/apache/skywalking/pull/4529>
>> >
>> > —————
>> > Best regards,
>> > Daming(@dmsolr)
>> > Apache SkyWalking
>> >
>> >
>> >
>> >
>> >
>> > > 在 2020年3月17日，上午10:49，han liu <mr...@gmail.com> 写道：
>> > >
>> > > Hi Sheng Wu
>> > >
>> > > This bug has fixed, and I have provided the PR[1], please have a look.
>> > > This issue because I put the recheck profiling status in the wrong
>> place,
>> > > the old way is to put the recheck on the `
>> > > AbstractTracingSpan#setOperationName`, so if the operation name
>> already
>> > > exists on the agent, this method will not invoke again.
>> > > If I put the status check on the each `createSpan` when parentSpan ==
>> > null,
>> > > also cannot fix it, because the change name operation happened on the
>> > > parentSpan != null and parentSpan is an entry span.
>> > >
>> > > [1] https://github.com/apache/skywalking/pull/4528
>> > >
>> > > Sheng Wu <wu...@gmail.com> 于2020年3月17日周二 上午8:55写道：
>> > >
>> > >> Hi Han Liu
>> > >>
>> > >> I found an issue or we could say the unperfect feature of profiling,
>> in
>> > the
>> > >> demo env, if I call profile for `/projectB/{value}`, nothing shows
>> up.
>> > >> I read the codes, and find out,
>> > >>> PROFILE_TASK_EXECUTION_SERVICE.addProfiling(this,
>> > >> segment.getTraceSegmentId(), firstOPName);
>> > >> This is only in the TracingContext constructor, but in the SprinvMVC
>> > case,
>> > >> in default mode, the Tomcat plugin would work first and create a
>> tracing
>> > >> context.
>> > >> The better is, you should call this in every `createSpan` method when
>> > then
>> > >> parentSpan == null (meaning the first span)
>> > >> Please fix this ASAP, as I could see this is a normal use case and
>> > should
>> > >> be treated as a block to do the release.
>> > >>
>> > >> Sheng Wu 吴晟
>> > >> Twitter, wusheng1108
>> > >>
>> > >>
>> > >> Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:43写道：
>> > >>
>> > >>> Based on CI and E2E[1], we are safe on the basic agent and backend
>> > >>> feature.
>> > >>> But still would be better to have test results from the developer
>> > >> manually.
>> > >>>
>> > >>> Demo env will be updated soon.
>> > >>>
>> > >>> [1] https://github.com/apache/skywalking/actions?query=event%3Apush
>> > >>>
>> > >>> Sheng Wu 吴晟
>> > >>> Twitter, wusheng1108
>> > >>>
>> > >>>
>> > >>> Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:25写道：
>> > >>>
>> > >>>> Hi Dev team
>> > >>>>
>> > >>>> In the last 2 months, we focus on the new SkyWalking 7.0.0, now all
>> > >>>> features have been provided.
>> > >>>> We should begin to tests, give feedback about whether it is ready
>> to
>> > >>>> release and only accept PR about the bug fix.
>> > >>>>
>> > >>>> After the tests, I will begin the official release of 7.0.0.
>> > >>>>
>> > >>>> Sheng Wu 吴晟
>> > >>>> Twitter, wusheng1108
>> > >>>>
>> > >>>
>> > >>
>> >
>> >
>>
>
Re: [ACTION REQUIRE] SkyWalking 7.0.0 Release Test
Posted by Sheng Wu <wu...@gmail.com>.
The UI of the profile has passed the test locally and on the demo env.
But sadly, some profile UI related PRs override the old topology features.
I have forwarded the issue to Yao Wang, we need to wait for that fix and
test on the demo env again.
Sheng Wu 吴晟
Twitter, wusheng1108
han liu <mr...@gmail.com> 于2020年3月17日周二 下午11:22写道：
> Hi
>
> We have fixed some problems in the profile function:
> 1. PR[1]: Fix the analysis error in UI level, and increase the loading
> effect during analysis.
>
> [1]: https://github.com/apache/skywalking/pull/4521
>
> Daming <zt...@foxmail.com> 于2020年3月17日周二 下午3:02写道：
>
> > Hi
> > Here is a message about a bug fixed. I found a critical issue in
> > InfluxDB-plugin. It will cause AlarmQuery error. Now, it is fixed in
> PR[1].
> >
> > [1] https://github.com/apache/skywalking/pull/4529 <
> > https://github.com/apache/skywalking/pull/4529>
> >
> > —————
> > Best regards,
> > Daming(@dmsolr)
> > Apache SkyWalking
> >
> >
> >
> >
> >
> > > 在 2020年3月17日，上午10:49，han liu <mr...@gmail.com> 写道：
> > >
> > > Hi Sheng Wu
> > >
> > > This bug has fixed, and I have provided the PR[1], please have a look.
> > > This issue because I put the recheck profiling status in the wrong
> place,
> > > the old way is to put the recheck on the `
> > > AbstractTracingSpan#setOperationName`, so if the operation name already
> > > exists on the agent, this method will not invoke again.
> > > If I put the status check on the each `createSpan` when parentSpan ==
> > null,
> > > also cannot fix it, because the change name operation happened on the
> > > parentSpan != null and parentSpan is an entry span.
> > >
> > > [1] https://github.com/apache/skywalking/pull/4528
> > >
> > > Sheng Wu <wu...@gmail.com> 于2020年3月17日周二 上午8:55写道：
> > >
> > >> Hi Han Liu
> > >>
> > >> I found an issue or we could say the unperfect feature of profiling,
> in
> > the
> > >> demo env, if I call profile for `/projectB/{value}`, nothing shows up.
> > >> I read the codes, and find out,
> > >>> PROFILE_TASK_EXECUTION_SERVICE.addProfiling(this,
> > >> segment.getTraceSegmentId(), firstOPName);
> > >> This is only in the TracingContext constructor, but in the SprinvMVC
> > case,
> > >> in default mode, the Tomcat plugin would work first and create a
> tracing
> > >> context.
> > >> The better is, you should call this in every `createSpan` method when
> > then
> > >> parentSpan == null (meaning the first span)
> > >> Please fix this ASAP, as I could see this is a normal use case and
> > should
> > >> be treated as a block to do the release.
> > >>
> > >> Sheng Wu 吴晟
> > >> Twitter, wusheng1108
> > >>
> > >>
> > >> Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:43写道：
> > >>
> > >>> Based on CI and E2E[1], we are safe on the basic agent and backend
> > >>> feature.
> > >>> But still would be better to have test results from the developer
> > >> manually.
> > >>>
> > >>> Demo env will be updated soon.
> > >>>
> > >>> [1] https://github.com/apache/skywalking/actions?query=event%3Apush
> > >>>
> > >>> Sheng Wu 吴晟
> > >>> Twitter, wusheng1108
> > >>>
> > >>>
> > >>> Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:25写道：
> > >>>
> > >>>> Hi Dev team
> > >>>>
> > >>>> In the last 2 months, we focus on the new SkyWalking 7.0.0, now all
> > >>>> features have been provided.
> > >>>> We should begin to tests, give feedback about whether it is ready to
> > >>>> release and only accept PR about the bug fix.
> > >>>>
> > >>>> After the tests, I will begin the official release of 7.0.0.
> > >>>>
> > >>>> Sheng Wu 吴晟
> > >>>> Twitter, wusheng1108
> > >>>>
> > >>>
> > >>
> >
> >
>
Re: [ACTION REQUIRE] SkyWalking 7.0.0 Release Test
Posted by han liu <mr...@gmail.com>.
Hi
We have fixed some problems in the profile function:
1. PR[1]: Fix the analysis error in UI level, and increase the loading
effect during analysis.
[1]: https://github.com/apache/skywalking/pull/4521
Daming <zt...@foxmail.com> 于2020年3月17日周二 下午3:02写道：
> Hi
> Here is a message about a bug fixed. I found a critical issue in
> InfluxDB-plugin. It will cause AlarmQuery error. Now, it is fixed in PR[1].
>
> [1] https://github.com/apache/skywalking/pull/4529 <
> https://github.com/apache/skywalking/pull/4529>
>
> —————
> Best regards,
> Daming(@dmsolr)
> Apache SkyWalking
>
>
>
>
>
> > 在 2020年3月17日，上午10:49，han liu <mr...@gmail.com> 写道：
> >
> > Hi Sheng Wu
> >
> > This bug has fixed, and I have provided the PR[1], please have a look.
> > This issue because I put the recheck profiling status in the wrong place,
> > the old way is to put the recheck on the `
> > AbstractTracingSpan#setOperationName`, so if the operation name already
> > exists on the agent, this method will not invoke again.
> > If I put the status check on the each `createSpan` when parentSpan ==
> null,
> > also cannot fix it, because the change name operation happened on the
> > parentSpan != null and parentSpan is an entry span.
> >
> > [1] https://github.com/apache/skywalking/pull/4528
> >
> > Sheng Wu <wu...@gmail.com> 于2020年3月17日周二 上午8:55写道：
> >
> >> Hi Han Liu
> >>
> >> I found an issue or we could say the unperfect feature of profiling, in
> the
> >> demo env, if I call profile for `/projectB/{value}`, nothing shows up.
> >> I read the codes, and find out,
> >>> PROFILE_TASK_EXECUTION_SERVICE.addProfiling(this,
> >> segment.getTraceSegmentId(), firstOPName);
> >> This is only in the TracingContext constructor, but in the SprinvMVC
> case,
> >> in default mode, the Tomcat plugin would work first and create a tracing
> >> context.
> >> The better is, you should call this in every `createSpan` method when
> then
> >> parentSpan == null (meaning the first span)
> >> Please fix this ASAP, as I could see this is a normal use case and
> should
> >> be treated as a block to do the release.
> >>
> >> Sheng Wu 吴晟
> >> Twitter, wusheng1108
> >>
> >>
> >> Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:43写道：
> >>
> >>> Based on CI and E2E[1], we are safe on the basic agent and backend
> >>> feature.
> >>> But still would be better to have test results from the developer
> >> manually.
> >>>
> >>> Demo env will be updated soon.
> >>>
> >>> [1] https://github.com/apache/skywalking/actions?query=event%3Apush
> >>>
> >>> Sheng Wu 吴晟
> >>> Twitter, wusheng1108
> >>>
> >>>
> >>> Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:25写道：
> >>>
> >>>> Hi Dev team
> >>>>
> >>>> In the last 2 months, we focus on the new SkyWalking 7.0.0, now all
> >>>> features have been provided.
> >>>> We should begin to tests, give feedback about whether it is ready to
> >>>> release and only accept PR about the bug fix.
> >>>>
> >>>> After the tests, I will begin the official release of 7.0.0.
> >>>>
> >>>> Sheng Wu 吴晟
> >>>> Twitter, wusheng1108
> >>>>
> >>>
> >>
>
>
Re: [ACTION REQUIRE] SkyWalking 7.0.0 Release Test
Posted by Daming <zt...@foxmail.com>.
Hi
Here is a message about a bug fixed. I found a critical issue in InfluxDB-plugin. It will cause AlarmQuery error. Now, it is fixed in PR[1].
[1] https://github.com/apache/skywalking/pull/4529 <https://github.com/apache/skywalking/pull/4529>
—————
Best regards,
Daming(@dmsolr)
Apache SkyWalking
> 在 2020年3月17日，上午10:49，han liu <mr...@gmail.com> 写道：
>
> Hi Sheng Wu
>
> This bug has fixed, and I have provided the PR[1], please have a look.
> This issue because I put the recheck profiling status in the wrong place,
> the old way is to put the recheck on the `
> AbstractTracingSpan#setOperationName`, so if the operation name already
> exists on the agent, this method will not invoke again.
> If I put the status check on the each `createSpan` when parentSpan == null,
> also cannot fix it, because the change name operation happened on the
> parentSpan != null and parentSpan is an entry span.
>
> [1] https://github.com/apache/skywalking/pull/4528
>
> Sheng Wu <wu...@gmail.com> 于2020年3月17日周二 上午8:55写道：
>
>> Hi Han Liu
>>
>> I found an issue or we could say the unperfect feature of profiling, in the
>> demo env, if I call profile for `/projectB/{value}`, nothing shows up.
>> I read the codes, and find out,
>>> PROFILE_TASK_EXECUTION_SERVICE.addProfiling(this,
>> segment.getTraceSegmentId(), firstOPName);
>> This is only in the TracingContext constructor, but in the SprinvMVC case,
>> in default mode, the Tomcat plugin would work first and create a tracing
>> context.
>> The better is, you should call this in every `createSpan` method when then
>> parentSpan == null (meaning the first span)
>> Please fix this ASAP, as I could see this is a normal use case and should
>> be treated as a block to do the release.
>>
>> Sheng Wu 吴晟
>> Twitter, wusheng1108
>>
>>
>> Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:43写道：
>>
>>> Based on CI and E2E[1], we are safe on the basic agent and backend
>>> feature.
>>> But still would be better to have test results from the developer
>> manually.
>>>
>>> Demo env will be updated soon.
>>>
>>> [1] https://github.com/apache/skywalking/actions?query=event%3Apush
>>>
>>> Sheng Wu 吴晟
>>> Twitter, wusheng1108
>>>
>>>
>>> Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:25写道：
>>>
>>>> Hi Dev team
>>>>
>>>> In the last 2 months, we focus on the new SkyWalking 7.0.0, now all
>>>> features have been provided.
>>>> We should begin to tests, give feedback about whether it is ready to
>>>> release and only accept PR about the bug fix.
>>>>
>>>> After the tests, I will begin the official release of 7.0.0.
>>>>
>>>> Sheng Wu 吴晟
>>>> Twitter, wusheng1108
>>>>
>>>
>>
Re: [ACTION REQUIRE] SkyWalking 7.0.0 Release Test
Posted by han liu <mr...@gmail.com>.
Hi Sheng Wu
This bug has fixed, and I have provided the PR[1], please have a look.
This issue because I put the recheck profiling status in the wrong place,
the old way is to put the recheck on the `
AbstractTracingSpan#setOperationName`, so if the operation name already
exists on the agent, this method will not invoke again.
If I put the status check on the each `createSpan` when parentSpan == null,
also cannot fix it, because the change name operation happened on the
parentSpan != null and parentSpan is an entry span.
[1] https://github.com/apache/skywalking/pull/4528
Sheng Wu <wu...@gmail.com> 于2020年3月17日周二 上午8:55写道：
> Hi Han Liu
>
> I found an issue or we could say the unperfect feature of profiling, in the
> demo env, if I call profile for `/projectB/{value}`, nothing shows up.
> I read the codes, and find out,
> > PROFILE_TASK_EXECUTION_SERVICE.addProfiling(this,
> segment.getTraceSegmentId(), firstOPName);
> This is only in the TracingContext constructor, but in the SprinvMVC case,
> in default mode, the Tomcat plugin would work first and create a tracing
> context.
> The better is, you should call this in every `createSpan` method when then
> parentSpan == null (meaning the first span)
> Please fix this ASAP, as I could see this is a normal use case and should
> be treated as a block to do the release.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:43写道：
>
> > Based on CI and E2E[1], we are safe on the basic agent and backend
> > feature.
> > But still would be better to have test results from the developer
> manually.
> >
> > Demo env will be updated soon.
> >
> > [1] https://github.com/apache/skywalking/actions?query=event%3Apush
> >
> > Sheng Wu 吴晟
> > Twitter, wusheng1108
> >
> >
> > Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:25写道：
> >
> >> Hi Dev team
> >>
> >> In the last 2 months, we focus on the new SkyWalking 7.0.0, now all
> >> features have been provided.
> >> We should begin to tests, give feedback about whether it is ready to
> >> release and only accept PR about the bug fix.
> >>
> >> After the tests, I will begin the official release of 7.0.0.
> >>
> >> Sheng Wu 吴晟
> >> Twitter, wusheng1108
> >>
> >
>
Re: [ACTION REQUIRE] SkyWalking 7.0.0 Release Test
Posted by Sheng Wu <wu...@gmail.com>.
Hi Han Liu
I found an issue or we could say the unperfect feature of profiling, in the
demo env, if I call profile for `/projectB/{value}`, nothing shows up.
I read the codes, and find out,
> PROFILE_TASK_EXECUTION_SERVICE.addProfiling(this,
segment.getTraceSegmentId(), firstOPName);
This is only in the TracingContext constructor, but in the SprinvMVC case,
in default mode, the Tomcat plugin would work first and create a tracing
context.
The better is, you should call this in every `createSpan` method when then
parentSpan == null (meaning the first span)
Please fix this ASAP, as I could see this is a normal use case and should
be treated as a block to do the release.
Sheng Wu 吴晟
Twitter, wusheng1108
Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:43写道：
> Based on CI and E2E[1], we are safe on the basic agent and backend
> feature.
> But still would be better to have test results from the developer manually.
>
> Demo env will be updated soon.
>
> [1] https://github.com/apache/skywalking/actions?query=event%3Apush
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:25写道：
>
>> Hi Dev team
>>
>> In the last 2 months, we focus on the new SkyWalking 7.0.0, now all
>> features have been provided.
>> We should begin to tests, give feedback about whether it is ready to
>> release and only accept PR about the bug fix.
>>
>> After the tests, I will begin the official release of 7.0.0.
>>
>> Sheng Wu 吴晟
>> Twitter, wusheng1108
>>
>
Re: [ACTION REQUIRE] SkyWalking 7.0.0 Release Test
Posted by Sheng Wu <wu...@gmail.com>.
Based on CI and E2E[1], we are safe on the basic agent and backend feature.
But still would be better to have test results from the developer manually.
Demo env will be updated soon.
[1] https://github.com/apache/skywalking/actions?query=event%3Apush
Sheng Wu 吴晟
Twitter, wusheng1108
Sheng Wu <wu...@gmail.com> 于2020年3月16日周一 下午3:25写道：
> Hi Dev team
>
> In the last 2 months, we focus on the new SkyWalking 7.0.0, now all
> features have been provided.
> We should begin to tests, give feedback about whether it is ready to
> release and only accept PR about the bug fix.
>
> After the tests, I will begin the official release of 7.0.0.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>