You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by wangmiao1981 <gi...@git.apache.org> on 2017/06/12 05:32:43 UTC
[GitHub] flink pull request #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass...
GitHub user wangmiao1981 opened a pull request:
https://github.com/apache/flink/pull/4106
[FLINK-6788]:Remove unused GenericFlatTypePostPass/AbstractSchema class
Removed two unused classes by deleting corresponding files.
Build Success. Run `mvn clean verify` Optimizer module and existing other tests are passed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangmiao1981/flink remove
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4106
----
commit c82f6ca851ff5a061517a8d2bcf1b6ea70bb62d3
Author: Miao Wang <wa...@users.noreply.github.com>
Date: 2016-02-25T23:46:51Z
Merge pull request #1 from apache/master
merge code
commit 1db4214f99bf9586466fc3fbf991d3f50be834fb
Author: m.wang <m....@us-136765mp.local>
Date: 2017-06-01T00:43:11Z
Merge github.com:apache/flink
commit 3210d6eb985304d5381ff15ec5bd991f3059408f
Author: m.wang <m....@us-136765mp.local>
Date: 2017-06-12T05:29:51Z
remove unused classes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...
Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on the issue:
https://github.com/apache/flink/pull/4106
let me do one more thing to set git user and git email. Just a second. I am using a new laptop now :)
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...
Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on the issue:
https://github.com/apache/flink/pull/4106
retest please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4106
Much better. Are you aware that the commit will not be attributed to your github account (because the username/email aren't in sync between your local git and your account)?
The changes themselves are good to merge though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass...
Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 closed the pull request at:
https://github.com/apache/flink/pull/4106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...
Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on the issue:
https://github.com/apache/flink/pull/4106
It seems that I massed up this PR.
Let me close it and resubmit a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4106
You still have to re-create the commit so the settings are applied to it.
I would do it like this:
```
git reset HEAD^
git add *
git commit
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4106
We are aware that some tests are unstable; we don't need to re-run travis.
Could you rework your branch so that it doesn't include a merge commit by re-basing it on-top of the current master? Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4106
well it's ok, but now you could just remove the first 2 commits in the branch. :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...
Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on the issue:
https://github.com/apache/flink/pull/4106
@zentol Thanks for your time! It is strange that it includes a merge. Let me rebase my branch and push again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...
Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on the issue:
https://github.com/apache/flink/pull/4106
I did one revert and recommit. Is it acceptable now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...
Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on the issue:
https://github.com/apache/flink/pull/4106
flink_ws_05_31 m.wang$ git config --list
....
remote.origin.url=git@github.com:wangmiao1981/flink.git
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
branch.master.remote=origin
branch.master.merge=refs/heads/master
remote.upstream.url=git@github.com:apache/flink.git
remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
user.name=wangmiao1981
user.email=wm624@hotmail.com
I pushed again. Above is my local username and email setup.
Are they synced now?
Thanks!
Miao
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---