You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/04/08 02:28:08 UTC
[GitHub] [incubator-dubbo] codecov-io commented on issue #3823: polish code

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3823?src=pr&el=h1) Report
> Merging [#3823](https://codecov.io/gh/apache/incubator-dubbo/pull/3823?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/fb5d96de60716a0ea7fbd5eb41731b4d67e3a803?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `61.11%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3823?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3823      +/-   ##
============================================
- Coverage     63.62%   63.56%   -0.06%     
  Complexity       71       71              
============================================
  Files           704      704              
  Lines         31065    31062       -3     
  Branches       5037     5037              
============================================
- Hits          19764    19744      -20     
- Misses         9032     9044      +12     
- Partials       2269     2274       +5
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3823?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...PropertyDefaultValueDubboConfigBeanCustomizer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9jb25maWcvTmFtZVByb3BlcnR5RGVmYXVsdFZhbHVlRHViYm9Db25maWdCZWFuQ3VzdG9taXplci5qYXZh) | `66.66% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...dubbo/config/spring/util/PropertySourcesUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9Qcm9wZXJ0eVNvdXJjZXNVdGlscy5qYXZh) | `86.95% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1JlZmVyZW5jZUFubm90YXRpb25CZWFuUG9zdFByb2Nlc3Nvci5qYXZh) | `82.66% <100%> (-0.88%)` | `0 <0> (ø)` | |
| [...nnotation/DubboConfigBindingBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQmluZGluZ0JlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `73.21% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...onfig/spring/schema/DubboBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvc2NoZW1hL0R1YmJvQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `67.42% <100%> (+0.14%)` | `0 <0> (ø)` | :arrow_down: |
| [...nnotation/AnnotationInjectedBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL0Fubm90YXRpb25JbmplY3RlZEJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `65.75% <52%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...annotation/ServiceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1NlcnZpY2VBbm5vdGF0aW9uQmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `82.48% <66.66%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (-10.87%)` | `0% <0%> (ø)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-3.28%)` | `0% <0%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3823/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3823?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3823?src=pr&el=footer). Last update [fb5d96d...9838fb7](https://codecov.io/gh/apache/incubator-dubbo/pull/3823?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3823 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org