[GitHub] [flink] hlteoh37 opened a new pull request, #21538: [FLINK-24386] Guard JobMaster against exceptions from starting the Op…

[GitBox <gi...@apache.org>]

hlteoh37 opened a new pull request, #21538:
URL: https://github.com/apache/flink/pull/21538

   …eratorCoordinator
   
   ## What is the purpose of the change
   * Improve the stability of the JobMaster when OperatorCoordinator throws an Exception upon start(). Instead of restarting the entire JobMaster, we will directly restart the job instead.
   
   ## Brief change log
   * Catch non-fatal Throwables when starting OperatorCoordinator, and fail the job instead of rethrowing the JobMaster main thread.
   
   ## Verifying this change
   This change added tests and can be verified as follows:
   - Added unit test to verify that an OperatorCoordinator exception triggers a job failure without terminating the running thread.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21538: [FLINK-24386] Guard JobMaster against exceptions from starting the Op…

[GitBox <gi...@apache.org>]

flinkbot commented on PR #21538:
URL: https://github.com/apache/flink/pull/21538#issuecomment-1359782359

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0f68db2a53d68bb850f6cd0ac285075e144f38ab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0f68db2a53d68bb850f6cd0ac285075e144f38ab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0f68db2a53d68bb850f6cd0ac285075e144f38ab UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hlteoh37 commented on pull request #21538: [FLINK-24386] Guard JobMaster against exceptions from starting the Op…

["hlteoh37 (via GitHub)" <gi...@apache.org>]

hlteoh37 commented on PR #21538:
URL: https://github.com/apache/flink/pull/21538#issuecomment-1540023419

   Converted to draft because this change needs a lot more testing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org