[GitHub] [dubbo-getty] AlexStocks removed a comment on pull request #56: Ftr: delete session.handleLoop

[GitBox <gi...@apache.org>]

AlexStocks removed a comment on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-874855101


   > this pr include the following changes:
   > 
   > 1. replace `sync/atomic` using `go.uber.org/atomic`
   > 2. upgrade `gxtime.Wheel` to `gxtime.TimerWheel`
   > 3. delete session heartbeat loop handle, and add it into the `TimerWheel` instead to reduce the count of goroutines.
   > 4. add benchmark code
   
   Can not agree with u on suggestion 2. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org