You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by bu...@apache.org on 2007/05/02 23:15:42 UTC

DO NOT REPLY [Bug 42304] - P4Label task doesn't support the new 'revision' field for Perforce labels

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42304>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42304


brian.hartin@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20077|0                           |1
           is patch|                            |




------- Additional Comments From brian.hartin@gmail.com  2007-05-02 14:15 -------
(From update of attachment 20077)
Compare: (<)C:\temp\Document1.txt (5730 bytes)
   with: (>)C:\temp\Document2.txt (6161 bytes)

51a51
>     protected String revision;
78a79,86
>      * Sets the optional revision field.
>      * @param revision The optional revision
>      */
>     public void setRevision(String revision) {
>         this.revision = revision;
>     }
> 
>     /**
110d119
< 
115,116c123,129
<		  + "\nOptions: unlocked"
<		  + "\nView: \n\t" + P4View;
---
>                 + "\nOptions: unlocked";
> 
>         if (revision != null && revision.length() >= 1) {
> 		    newLabel = newLabel + "\nRevision: " + revision;
> 		}
> 
>         newLabel = newLabel + "\nView: \n\t" + P4View;
128,133c141,147
<	  execP4Command("labelsync -l " + name, new P4HandlerAdapter() {
<	      public void process(String line) {
<		  log(line, Project.MSG_VERBOSE);
<	      }
<	  });
< 
---
>         if(revision == null || revision.length() < 1) {
> 	        execP4Command("labelsync -l " + name, new P4HandlerAdapter() {
> 	            public void process(String line) {
> 	                log(line, Project.MSG_VERBOSE);
> 	            }
>         	});
>  		}


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org