You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/10 17:57:34 UTC
[GitHub] [arrow] fatemehp opened a new pull request, #14366: PARQUET-2179: [parquet-cpp] Add a test for skipping repeated fields
fatemehp opened a new pull request, #14366:
URL: https://github.com/apache/arrow/pull/14366
Add a test for skipping repeated fields to make it clear that we are skipping values and not records. Also, added some comments to the existing test for Skip of non-repeated values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fatemehp commented on pull request #14366: PARQUET-2179: [C++][Parquet] Add a test for skipping repeated fields
Posted by GitBox <gi...@apache.org>.
fatemehp commented on PR #14366:
URL: https://github.com/apache/arrow/pull/14366#issuecomment-1276501213
This is a test for TypedColumnReader::Skip, and not relevant to the RecordReader. I am trying to keep the changes small and self-contained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14366: PARQUET-2179: [C++][Parquet] Add a test for skipping repeated fields
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14366:
URL: https://github.com/apache/arrow/pull/14366#issuecomment-1282523302
Let's wait for CI before merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fatemehp commented on pull request #14366: PARQUET-2179: [C++][Parquet] Add a test for skipping repeated fields
Posted by GitBox <gi...@apache.org>.
fatemehp commented on PR #14366:
URL: https://github.com/apache/arrow/pull/14366#issuecomment-1276505271
@emkornfield yes, there are some commits here that are not part of this change. I will remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14366: PARQUET-2179: [parquet-cpp] Add a test for skipping repeated fields
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14366:
URL: https://github.com/apache/arrow/pull/14366#issuecomment-1273648911
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fatemehp commented on pull request #14366: PARQUET-2179: [C++][Parquet] Add a test for skipping repeated fields
Posted by GitBox <gi...@apache.org>.
fatemehp commented on PR #14366:
URL: https://github.com/apache/arrow/pull/14366#issuecomment-1281399130
Ok, I think I have fixed this. @emkornfield, could you take a look and merge this change if everything looks good? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14366: PARQUET-2179: [C++][Parquet] Add a test for skipping repeated fields
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14366:
URL: https://github.com/apache/arrow/pull/14366#issuecomment-1282860102
CI failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fatemehp commented on pull request #14366: PARQUET-2179: [parquet-cpp] Add a test for skipping repeated fields
Posted by GitBox <gi...@apache.org>.
fatemehp commented on PR #14366:
URL: https://github.com/apache/arrow/pull/14366#issuecomment-1273657269
@emkornfield can you merge this pull request? You already reviewed it, but the pull request was not against the master. This includes some commits that are already checked in. I am not sure how to remove them. You can try looking at the changes from "Merge pull request #1 from fatemehp/skip_test".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #14366: PARQUET-2179: [C++][Parquet] Add a test for skipping repeated fields
Posted by GitBox <gi...@apache.org>.
emkornfield commented on PR #14366:
URL: https://github.com/apache/arrow/pull/14366#issuecomment-1276499916
@fatemehp it looks like this merged commits from the SkipRecords with the additional tests for Skip method that only skips values, could you remove some of the commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14366: PARQUET-2179: [parquet-cpp] Add a test for skipping repeated fields
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14366:
URL: https://github.com/apache/arrow/pull/14366#issuecomment-1273648894
https://issues.apache.org/jira/browse/PARQUET-2179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14366: PARQUET-2179: [C++][Parquet] Add a test for skipping repeated fields
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14366:
URL: https://github.com/apache/arrow/pull/14366#issuecomment-1274356723
@fatemehp Why did you submit this in addition to #14142?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #14366: PARQUET-2179: [C++][Parquet] Add a test for skipping repeated fields
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #14366:
URL: https://github.com/apache/arrow/pull/14366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org