[GitHub] [spark] cloud-fan commented on a change in pull request #27471: [SPARK-30744][SQL] Optimize AnalyzePartitionCommand by calculating location sizes in parallel

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27471: [SPARK-30744][SQL] Optimize AnalyzePartitionCommand by calculating location sizes in parallel
URL: https://github.com/apache/spark/pull/27471#discussion_r375676767
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
 ##########
 @@ -153,11 +153,12 @@ object CommandUtils extends Logging {
    * for each path.
    * @param sparkSession the [[SparkSession]]
    * @param paths the Seq of [[Option[Path]]]s
-   * @return total size of all partitions
+   * @return a Seq of same size as `paths` where i-th element is total size of `paths(i)` or 0
+   *         if `paths(i)` is None
    */
-  def calculateLocationSizeParallel(
+  def calculateLocationsSizeInParallel(
 
 Review comment:
   let's be consistent `calculateMultipleLocationSizesInParallel`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org