You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/08/26 19:35:10 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3724: HDDS-7171. Add SupportedSourceVersion in annotation processors
adoroszlai opened a new pull request, #3724:
URL: https://github.com/apache/ozone/pull/3724
## What changes were proposed in this pull request?
Get rid of the warning:
```
[INFO] --- aspectj-maven-plugin:1.14.0:compile (default) @ ozone-manager ---
[INFO] Showing AJC message detail for messages of types: [error, warning, fail]
[WARNING] No SupportedSourceVersion annotation found on org.apache.hadoop.hdds.conf.ConfigFileGenerator, returning RELEASE_6.
<unknown source file>:<no line information>
[WARNING] No SupportedSourceVersion annotation found on org.apache.ozone.annotations.ReplicateAnnotationProcessor, returning RELEASE_6.
<unknown source file>:<no line information>
```
https://issues.apache.org/jira/browse/HDDS-7171
## How was this patch tested?
Built locally, verified no warnings:
```
[INFO] --- aspectj-maven-plugin:1.14.0:compile (default) @ ozone-manager ---
[INFO] Showing AJC message detail for messages of types: [error, warning, fail]
[INFO]
```
https://github.com/adoroszlai/hadoop-ozone/actions/runs/2935378198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3724: HDDS-7171. Add SupportedSourceVersion in annotation processors
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3724:
URL: https://github.com/apache/ozone/pull/3724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on a diff in pull request #3724: HDDS-7171. Add SupportedSourceVersion in annotation processors
Posted by GitBox <gi...@apache.org>.
kerneltime commented on code in PR #3724:
URL: https://github.com/apache/ozone/pull/3724#discussion_r957722105
##########
hadoop-hdds/annotations/src/main/java/org/apache/ozone/annotations/ReplicateAnnotationProcessor.java:
##########
@@ -35,6 +37,7 @@
* TimeoutException.
*/
@SupportedAnnotationTypes("org.apache.hadoop.hdds.scm.metadata.Replicate")
+@SupportedSourceVersion(SourceVersion.RELEASE_8)
Review Comment:
Nit: Is there a way to pick up this value from the configured version for the build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3724: HDDS-7171. Add SupportedSourceVersion in annotation processors
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3724:
URL: https://github.com/apache/ozone/pull/3724#issuecomment-1230523237
CC @GeorgeJahad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3724: HDDS-7171. Add SupportedSourceVersion in annotation processors
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3724:
URL: https://github.com/apache/ozone/pull/3724#issuecomment-1235135277
Thanks @GeorgeJahad, @kerneltime for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on a diff in pull request #3724: HDDS-7171. Add SupportedSourceVersion in annotation processors
Posted by GitBox <gi...@apache.org>.
kerneltime commented on code in PR #3724:
URL: https://github.com/apache/ozone/pull/3724#discussion_r957722105
##########
hadoop-hdds/annotations/src/main/java/org/apache/ozone/annotations/ReplicateAnnotationProcessor.java:
##########
@@ -35,6 +37,7 @@
* TimeoutException.
*/
@SupportedAnnotationTypes("org.apache.hadoop.hdds.scm.metadata.Replicate")
+@SupportedSourceVersion(SourceVersion.RELEASE_8)
Review Comment:
Is there a way to pick up this value from the configured version for the build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GeorgeJahad commented on pull request #3724: HDDS-7171. Add SupportedSourceVersion in annotation processors
Posted by GitBox <gi...@apache.org>.
GeorgeJahad commented on PR #3724:
URL: https://github.com/apache/ozone/pull/3724#issuecomment-1230838925
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org