You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/17 20:52:27 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4953: Minor: Make messages consistent for LogicalPlan::Dml
alamb opened a new pull request, #4953:
URL: https://github.com/apache/arrow-datafusion/pull/4953
# Which issue does this PR close?
Follow on to https://github.com/apache/arrow-datafusion/pull/4902 from @avantgardnerio
# Rationale for this change
There are some messages / display strings that appear to still reference an older version of the code
# What changes are included in this PR?
Update the display name to `Dml` everywhere
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4953: Minor: Make messages consistent for LogicalPlan::Dml
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4953:
URL: https://github.com/apache/arrow-datafusion/pull/4953#issuecomment-1386635748
Benchmark runs are scheduled for baseline = 4623166c50bfb6cdc53cb9d8af5ae68efb1d36a4 and contender = 906896b7c59ff14d71b3056ec4349274cf6662af. 906896b7c59ff14d71b3056ec4349274cf6662af is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a6f0415ab37c45bfb940d79ced6e00ef...2baf43b332d848e4b644ccb8d214f1d9/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b695e100abcc42a1ac1e542d27fb4c8d...4ff2f1a4405c43e29d67398ef336d8b4/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e9f63ffc4456427d824ee0b46c1e498d...b506651f836b4b95af722917b0b41c44/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/94c0c7eb0f714c169be246ba20d6fea0...8d513e7ccdb24b11bdce673f02ff79e9/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #4953: Minor: Make messages consistent for LogicalPlan::Dml
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #4953:
URL: https://github.com/apache/arrow-datafusion/pull/4953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4953: Minor: Make messages consistent for LogicalPlan::Dml
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4953:
URL: https://github.com/apache/arrow-datafusion/pull/4953#issuecomment-1386044903
> Thanks for catching this 🙌
I figured this would be faster than going through another round of review on https://github.com/apache/arrow-datafusion/pull/4902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org