You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/17 15:03:10 UTC
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5262: GEODE-8269: Improve test coverage
sabbeyPivotal commented on a change in pull request #5262:
URL: https://github.com/apache/geode/pull/5262#discussion_r441615674
##########
File path: geode-redis/src/test/java/org/apache/geode/redis/internal/executor/key/ExpireAtExecutorJUnitTest.java
##########
@@ -34,30 +37,30 @@
@Test
public void calledWithTooFewCommandArguments_returnsError() {
- List<byte[]> commandsAsBytesWithTooFewArguments = new ArrayList<>();
- commandsAsBytesWithTooFewArguments.add("EXPIREAT".getBytes());
- commandsAsBytesWithTooFewArguments.add("key".getBytes());
- Command command = new Command(commandsAsBytesWithTooFewArguments);
+ List<byte[]> commandAsBytes = new ArrayList<>();
+ commandAsBytes.add("EXPIREAT".getBytes());
+ commandAsBytes.add("key".getBytes());
+ Command command = new Command(commandAsBytes);
- RedisResponse response =
- new ExpireAtExecutor().executeCommand(command, mockContext());
+ Throwable thrown = catchThrowable(() -> command.execute(mockContext()));
Review comment:
yeah! good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org