You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/07 01:29:30 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
HyukjinKwon commented on a change in pull request #33917:
URL: https://github.com/apache/spark/pull/33917#discussion_r703118025
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala
##########
@@ -80,6 +82,18 @@ class SparkHadoopUtilSuite extends SparkFunSuite {
assertConfigValue(hadoopConf, "fs.s3a.endpoint", null)
}
+ /**
+ * test for _HOST pattern replacement with Server cannonical address
+ */
+ test("server principal with _HOST pattern") {
Review comment:
Maybe let's add a JIRA prefix in the test title:
```suggestion
test("SPARK-36622: server principal with _HOST pattern") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org