You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2006/04/05 21:27:54 UTC

svn commit: r391740 - /jakarta/jmeter/branches/rel-2-1/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java

Author: sebb
Date: Wed Apr  5 12:27:52 2006
New Revision: 391740

URL: http://svn.apache.org/viewcvs?rev=391740&view=rev
Log:
Tidy up; add NLS markers

Modified:
    jakarta/jmeter/branches/rel-2-1/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java

Modified: jakarta/jmeter/branches/rel-2-1/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
URL: http://svn.apache.org/viewcvs/jakarta/jmeter/branches/rel-2-1/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java?rev=391740&r1=391739&r2=391740&view=diff
==============================================================================
--- jakarta/jmeter/branches/rel-2-1/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java (original)
+++ jakarta/jmeter/branches/rel-2-1/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java Wed Apr  5 12:27:52 2006
@@ -90,9 +90,9 @@
  */
 public class ViewResultsFullVisualizer extends AbstractVisualizer implements ActionListener, TreeSelectionListener,
 		Clearable {
-	private static final String XML_PFX = "<?xml ";
+	private static final Logger log = LoggingManager.getLoggerForClass();
 
-	transient private static Logger log = LoggingManager.getLoggerForClass();
+	private static final String XML_PFX = "<?xml "; // $NON-NLS-1$
 
 	public final static Color SERVER_ERROR_COLOR = Color.red;
 
@@ -116,6 +116,12 @@
 
 	private static final String TEXT_COMMAND = "text"; // $NON-NLS-1$
 
+	private static final String STYLE_SERVER_ERROR = "ServerError"; // $NON-NLS-1$
+
+	private static final String STYLE_CLIENT_ERROR = "ClientError"; // $NON-NLS-1$
+
+	private static final String STYLE_REDIRECT = "Redirect"; // $NON-NLS-1$
+
 	private boolean textMode = true;
 
 	// set default command to Text
@@ -162,7 +168,7 @@
 	}
 
 	public String getLabelResource() {
-		return "view_results_tree_title";
+		return "view_results_tree_title"; // $NON-NLS-1$
 	}
 
 	/**
@@ -216,8 +222,8 @@
 			treeModel.removeNodeFromParent((DefaultMutableTreeNode) root.getChildAt(0));
 		}
 
-		results.setText("");// Response Data
-		sampleDataField.setText("");// Request Data
+		results.setText("");// Response Data // $NON-NLS-1$
+		sampleDataField.setText("");// Request Data // $NON-NLS-1$
 		log.debug("End : clear1");
 	}
 
@@ -249,8 +255,8 @@
 		StyledDocument statsDoc = stats.getStyledDocument();
 		try {
 			statsDoc.remove(0, statsDoc.getLength());
-			sampleDataField.setText("");
-			results.setText("");
+			sampleDataField.setText(""); // $NON-NLS-1$
+			results.setText(""); // $NON-NLS-1$
 			if (node != null) {
 				SampleResult res = (SampleResult) node.getUserObject();
 
@@ -292,13 +298,13 @@
 					Style style = null;
 					switch (responseLevel) {
 					case 3:
-						style = statsDoc.getStyle("Redirect");
+						style = statsDoc.getStyle(STYLE_REDIRECT);
 						break;
 					case 4:
-						style = statsDoc.getStyle("ClientError");
+						style = statsDoc.getStyle(STYLE_CLIENT_ERROR);
 						break;
 					case 5:
-						style = statsDoc.getStyle("ServerError");
+						style = statsDoc.getStyle(STYLE_SERVER_ERROR);
 						break;
 					}
 					statsDoc.insertString(statsDoc.getLength(), "HTTP response code: " + responseCode + "\n", style);
@@ -350,8 +356,8 @@
 	}
 
 	protected void showTextResponse(String response) {
-		results.setContentType("text/plain");
-		results.setText(response == null ? "" : response);
+		results.setContentType("text/plain"); // $NON-NLS-1$
+		results.setText(response == null ? "" : response); // $NON-NLS-1$
 		results.setCaretPosition(0);
 		resultsScrollPane.setViewportView(results);
 
@@ -365,8 +371,8 @@
 	private void showRenderXMLResponse(String response) {
 		String parsable="";
 		if (response == null) {
-			results.setText("");
-			parsable = "";
+			results.setText(""); // $NON-NLS-1$
+			parsable = ""; // $NON-NLS-1$
 		} else {
 			results.setText(response);
 			int start = response.indexOf(XML_PFX);
@@ -376,7 +382,7 @@
 			    parsable=response;
 			}
 		}
-		results.setContentType("text/xml");
+		results.setContentType("text/xml"); // $NON-NLS-1$
 		results.setCaretPosition(0);
 
 		Component view = results;
@@ -492,11 +498,11 @@
 			return;
 		}
 
-		int htmlIndex = response.indexOf("<HTML"); // could be <HTML lang="">
+		int htmlIndex = response.indexOf("<HTML"); // could be <HTML lang=""> // $NON-NLS-1$
 
 		// Look for a case variation
 		if (htmlIndex < 0) {
-			htmlIndex = response.indexOf("<html"); // ditto
+			htmlIndex = response.indexOf("<html"); // ditto // $NON-NLS-1$
 		}
 
 		// If we still can't find it, just try using all of the text
@@ -529,7 +535,7 @@
 		 * 
 		 * Is this due to a bug in Java?
 		 */
-		results.getDocument().putProperty("IgnoreCharsetDirective", Boolean.TRUE);
+		results.getDocument().putProperty("IgnoreCharsetDirective", Boolean.TRUE); // $NON-NLS-1$
 
 		results.setText(html);
 		results.setCaretPosition(0);
@@ -585,9 +591,9 @@
 		Component leftSide = createLeftPanel();
 		JTabbedPane rightSide = new JTabbedPane();
 
-		rightSide.addTab(JMeterUtils.getResString("view_results_tab_sampler"), createResponseMetadataPanel());
-		rightSide.addTab(JMeterUtils.getResString("view_results_tab_request"), createRequestPanel());
-		rightSide.addTab(JMeterUtils.getResString("view_results_tab_response"), createResponseDataPanel());
+		rightSide.addTab(JMeterUtils.getResString("view_results_tab_sampler"), createResponseMetadataPanel()); // $NON-NLS-1$
+		rightSide.addTab(JMeterUtils.getResString("view_results_tab_request"), createRequestPanel()); // $NON-NLS-1$
+		rightSide.addTab(JMeterUtils.getResString("view_results_tab_response"), createResponseDataPanel()); // $NON-NLS-1$
 
 		JSplitPane mainSplit = new JSplitPane(JSplitPane.HORIZONTAL_SPLIT, leftSide, rightSide);
 		add(mainSplit, BorderLayout.CENTER);
@@ -620,13 +626,13 @@
 		// Add styles to use for different types of status messages
 		StyledDocument doc = (StyledDocument) stats.getDocument();
 
-		Style style = doc.addStyle("Redirect", null);
+		Style style = doc.addStyle(STYLE_REDIRECT, null);
 		StyleConstants.setForeground(style, REDIRECT_COLOR);
 
-		style = doc.addStyle("ClientError", null);
+		style = doc.addStyle(STYLE_CLIENT_ERROR, null);
 		StyleConstants.setForeground(style, CLIENT_ERROR_COLOR);
 
-		style = doc.addStyle("ServerError", null);
+		style = doc.addStyle(STYLE_SERVER_ERROR, null);
 		StyleConstants.setForeground(style, SERVER_ERROR_COLOR);
 
 		JScrollPane pane = makeScrollPane(stats);
@@ -763,7 +769,7 @@
 				super.getTreeCellRendererComponent(tree, value, sel, expanded, leaf, row, phasFocus);
 
 				DefaultMutableTreeNode valueTreeNode = (DefaultMutableTreeNode) value;
-				setToolTipText(getHTML(valueTreeNode.toString(), "<br>", 100));
+				setToolTipText(getHTML(valueTreeNode.toString(), "<br>", 100)); // $NON-NLS-1$
 				return this;
 			}
 
@@ -776,7 +782,7 @@
 			 * @return
 			 */
 			private String getHTML(String str, String separator, int maxChar) {
-				StringBuffer strBuf = new StringBuffer("<html><body bgcolor=\"yellow\"><b>");
+				StringBuffer strBuf = new StringBuffer("<html><body bgcolor=\"yellow\"><b>"); // $NON-NLS-1$
 				char[] chars = str.toCharArray();
 				for (int i = 0; i < chars.length; i++) {
 
@@ -785,7 +791,7 @@
 					strBuf.append(encode(chars[i]));
 
 				}
-				strBuf.append("</b></body></html>");
+				strBuf.append("</b></body></html>"); // $NON-NLS-1$
 				return strBuf.toString();
 
 			}
@@ -793,17 +799,17 @@
 			private String encode(char c) {
 				String toReturn = String.valueOf(c);
 				switch (c) {
-				case '<':
-					toReturn = "&lt;";
+				case '<': // $NON-NLS-1$
+					toReturn = "&lt;"; // $NON-NLS-1$
 					break;
-				case '>':
-					toReturn = "&gt;";
+				case '>': // $NON-NLS-1$
+					toReturn = "&gt;"; // $NON-NLS-1$
 					break;
-				case '\'':
-					toReturn = "&apos;";
+				case '\'': // $NON-NLS-1$
+					toReturn = "&apos;"; // $NON-NLS-1$
 					break;
-				case '\"':
-					toReturn = "&quot;";
+				case '\"': // $NON-NLS-1$
+					toReturn = "&quot;"; // $NON-NLS-1$
 					break;
 
 				}
@@ -838,7 +844,7 @@
 		private int messageType;
 
 		public SAXErrorHandler() {
-			msg = "";
+			msg = ""; // $NON-NLS-1$
 
 		}
 



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org