You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "amogh-jahagirdar (via GitHub)" <gi...@apache.org> on 2023/04/19 00:44:04 UTC
[GitHub] [iceberg] amogh-jahagirdar opened a new pull request, #7372: Core: Fix flaky TestParallelIterable test
amogh-jahagirdar opened a new pull request, #7372:
URL: https://github.com/apache/iceberg/pull/7372
Fix flaky TestParallelIterable test https://github.com/apache/iceberg/issues/7367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #7372: Core: Fix flaky TestParallelIterable test
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 merged PR #7372:
URL: https://github.com/apache/iceberg/pull/7372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #7372: Core: Fix flaky TestParallelIterable test
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #7372:
URL: https://github.com/apache/iceberg/pull/7372#issuecomment-1514090971
Thanks for the quick fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #7372: Core: Fix flaky TestParallelIterable test
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #7372:
URL: https://github.com/apache/iceberg/pull/7372#discussion_r1170695331
##########
core/src/test/java/org/apache/iceberg/util/TestParallelIterable.java:
##########
@@ -60,9 +62,12 @@ public CloseableIterator<Integer> iterator() {
assertThat(iterator.hasNext()).isTrue();
assertThat(iterator.next()).isNotNull();
- assertThat(queue).isNotEmpty();
-
+ Awaitility.await("Queue is populated")
+ .atMost(5, TimeUnit.SECONDS)
+ .untilAsserted(() -> assertThat(queue).isNotEmpty());
Review Comment:
Actually the same may apply for the very first element offered to the queue, will fix that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org