[GitHub] [dolphinscheduler] JinyLeeChina commented on a change in pull request #5554: [Fix-5477][api] when start a process manually, its local parameter which references ${system.datetime} does not get runtime value

[GitBox <gi...@apache.org>]

JinyLeeChina commented on a change in pull request #5554:
URL: https://github.com/apache/dolphinscheduler/pull/5554#discussion_r649917105



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessInstanceServiceImpl.java
##########
@@ -621,23 +621,24 @@ private void setProcessInstance(ProcessInstance processInstance, Tenant tenant,
             throw new RuntimeException("workflow instance is null");
         }
 
+        Date scheduleTime = processInstance.getScheduleTime();
         Map<String, String> timeParams = BusinessTimeUtils
                 .getBusinessTime(processInstance.getCmdTypeIfComplement(),
-                        processInstance.getScheduleTime());
+                        scheduleTime !=null ? scheduleTime : processInstance.getStartTime());

Review comment:
       I think this need other way, if such a change is made here, it will have a great impact




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org