You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Andreas L Delmelle <a_...@pandora.be> on 2007/02/06 13:43:50 UTC

Re: svn commit: r503326 - in /xmlgraphics/fop/trunk: src/java-1.4/org/apache/fop/image/ImageIOImage.java status.xml

On Feb 3, 2007, at 23:31, jeremias@apache.org wrote:

Jeremias,

> Author: jeremias
> Date: Sat Feb  3 14:31:34 2007
> New Revision: 503326
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=503326
> Log:
> Bugzilla #41488:
> Fix for NPE with PNG images for RTF output.
> Submitted by: Dominic Brügger <bruegger.at.puzzle.ch>

<snip />

Have I overlooked something, or is this patch breaking several  
testcases?

More specifically, while building the latest revision, the following  
testcases fail:
- block-container_background-image_background-position-relative.xml
- external-graphic_png.xml
- inline_vertical-align_2.xml
- table-cell_background-image.xml

They all happen to use a PNG graphic...

Can you double-check?


Thanks,

Andreas


Re: svn commit: r503326 - in /xmlgraphics/fop/trunk: src/java-1.4/org/apache/fop/image/ImageIOImage.java status.xml

Posted by Simon Pepping <sp...@leverkruid.eu>.
On Tue, Feb 06, 2007 at 01:43:50PM +0100, Andreas L Delmelle wrote:
> Have I overlooked something, or is this patch breaking several  
> testcases?
> 
> More specifically, while building the latest revision, the following  
> testcases fail:
> - block-container_background-image_background-position-relative.xml
> - external-graphic_png.xml
> - inline_vertical-align_2.xml
> - table-cell_background-image.xml

Same failures here.

Simon

-- 
Simon Pepping
home page: http://www.leverkruid.eu

Re: svn commit: r503326 - in /xmlgraphics/fop/trunk: src/java-1.4/org/apache/fop/image/ImageIOImage.java status.xml

Posted by Andreas L Delmelle <a_...@pandora.be>.
On Feb 6, 2007, at 21:03, Jeremias Maerki wrote:

> Sorry about that.

No matter. Just checking if I could commit the fix for font-family  
names containing spaces.

I'll go right ahead, then.


Cheers,

Andreas

Re: svn commit: r503326 - in /xmlgraphics/fop/trunk: src/java-1.4/org/apache/fop/image/ImageIOImage.java status.xml

Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Sorry about that. Sloppy work on my part, not running the tests. I
should have known they'd break. After all, I even documented the
expected failure in the bugzilla issue. I'll revert or fix first thing
tomorrow morning CET when I've got some energy again.

On 06.02.2007 13:43:50 Andreas L Delmelle wrote:
> On Feb 3, 2007, at 23:31, jeremias@apache.org wrote:
> 
> Jeremias,
> 
> > Author: jeremias
> > Date: Sat Feb  3 14:31:34 2007
> > New Revision: 503326
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=503326
> > Log:
> > Bugzilla #41488:
> > Fix for NPE with PNG images for RTF output.
> > Submitted by: Dominic Brügger <bruegger.at.puzzle.ch>
> 
> <snip />
> 
> Have I overlooked something, or is this patch breaking several  
> testcases?
> 
> More specifically, while building the latest revision, the following  
> testcases fail:
> - block-container_background-image_background-position-relative.xml
> - external-graphic_png.xml
> - inline_vertical-align_2.xml
> - table-cell_background-image.xml
> 
> They all happen to use a PNG graphic...
> 
> Can you double-check?
> 
> 
> Thanks,
> 
> Andreas
> 



Jeremias Maerki