You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/09/08 15:20:46 UTC
[GitHub] [hop] shlxue opened a new pull request, #1675: HOP-4198, HOP-4005
shlxue opened a new pull request, #1675:
URL: https://github.com/apache/hop/pull/1675
When add pipeline to hop-server, the xml content could not be parsed using the correct encoding.
Many times, it is difficult to guarantee the same encoding used in http-client versus hop-server.
For example, Chinese Windows systems usually use gbk as the default encoding for the system. But hop-server may run on Linux and use UTF-8 as the default encoding.
If there are Chinese characters in the pipeline name, it may only show that there is a problem.
However, if Chinese characters are used in a path (ps: PipelineExecutor's hpl location), the file may not be loaded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1675: HOP-4198, HOP-4005
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1675:
URL: https://github.com/apache/hop/pull/1675#issuecomment-1243270821
Great addition @shlxue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1675: HOP-4198, HOP-4005
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1675:
URL: https://github.com/apache/hop/pull/1675#issuecomment-1241452853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1675: HOP-4198, HOP-4005
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1675:
URL: https://github.com/apache/hop/pull/1675#issuecomment-1240907063
api: registerPipeline/registerWorkflow
| Content-Type | http-client encoding | hop-server parse type |
|--------|---------|------|
| text/xml;charset=xxx | 1. xml header -> <br/>2. file.encoding(jvm) -> <br/>3. Const.XML_ENCODING | body:request.characterEncoding |
| binary/zip | append xml header | zip entry(xml): xml header |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1675: HOP-4198, HOP-4005
Posted by GitBox <gi...@apache.org>.
hansva merged PR #1675:
URL: https://github.com/apache/hop/pull/1675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1675: HOP-4198, HOP-4005
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1675:
URL: https://github.com/apache/hop/pull/1675#issuecomment-1240963021
[Chinese-in-transform-name](https://issues.apache.org/jira/secure/attachment/13049093/image-2022-09-08-21-54-56-858.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org