Add new JMX metrics.

[Pavel Pereslegin <xx...@gmail.com>]

Hello, Igniters.

For some monitoring tasks we need to access these metrics through JMX:

1. Total server nodes in cluster.
2. Current topology version.

We can’t access them via JMX for now. Do you mind if I create a ticket
to add them?

I believe, they should be added to TcpDiscoverySpiMBean.

@MXBeanDescription("Server nodes count.")
public int getTotalServerNodes();

@MXBeanDescription("Last topology version.")
public long getTopologyVersion();

Re: Add new JMX metrics.

[Pavel Pereslegin <xx...@gmail.com>]

Hello, Igniters.

I've prepared PR [1] for this task [2],
upsource review [3] and tests results [4].

Could someone review it?

[1] https://github.com/apache/ignite/pull/3007
[2] https://issues.apache.org/jira/browse/IGNITE-6844
[3] https://reviews.ignite.apache.org/ignite/review/IGNT-CR-394
[4] https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests&tab=projectOverview&branch_Ignite20Tests=pull/3007/head

2017-11-08 15:16 GMT+03:00 Pavel Pereslegin <xx...@gmail.com>:
> Yakov, thanks for your suggestion.
>
> I will create such MBean to include these metrics.
>
> 2017-11-07 20:11 GMT+03:00 Yakov Zhdanov <yz...@apache.org>:
>> This seems to be incorrect place for implementing it. I would think of
>> something more generic like IgniteClusterMBean. It should also work for any
>> implementation of discovery SPI if one ever appears =)
>>
>> --Yakov

Re: Add new JMX metrics.

[Pavel Pereslegin <xx...@gmail.com>]

Yakov, thanks for your suggestion.

I will create such MBean to include these metrics.

2017-11-07 20:11 GMT+03:00 Yakov Zhdanov <yz...@apache.org>:
> This seems to be incorrect place for implementing it. I would think of
> something more generic like IgniteClusterMBean. It should also work for any
> implementation of discovery SPI if one ever appears =)
>
> --Yakov

Re: Add new JMX metrics.

[Yakov Zhdanov <yz...@apache.org>]

This seems to be incorrect place for implementing it. I would think of
something more generic like IgniteClusterMBean. It should also work for any
implementation of discovery SPI if one ever appears =)

--Yakov