You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/02 12:22:09 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

Apache9 commented on a change in pull request #1588:
URL: https://github.com/apache/hbase/pull/1588#discussion_r418952304



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/CompactionThroughputControllerFactory.java
##########
@@ -33,10 +36,16 @@
   public static final String HBASE_THROUGHPUT_CONTROLLER_KEY =
       "hbase.regionserver.throughput.controller";
 
+  public static String currentControllerClassName =

Review comment:
       Why static? And do we really need to store the class name here? Why not just call the getClass method on the controller instance?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org