You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by vit1251 <gi...@git.apache.org> on 2014/09/02 23:08:09 UTC
[GitHub] ant pull request: Update runant.py
GitHub user vit1251 opened a pull request:
https://github.com/apache/ant/pull/1
Update runant.py
Resolve long path problem when starting antrun.py on Windows 7
os.system is bad idea to use
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vit1251/ant patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant/pull/1.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1
----
commit c600946f5d3fc7032538ed5bb6e0a992758a7c5e
Author: Vitold S <vi...@gmail.com>
Date: 2014-09-02T21:08:02Z
Update runant.py
Resolve long path problem when starting antrun.py on Windows 7
os.system is bad idea to use
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Update runant.py
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/1#issuecomment-63494396
I've taken the liberty and only committed the subset actually related to the path changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: [Trunk] Add a "quiet" attribute to GetTask to ea...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Update runant.py
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/1#issuecomment-63479967
OK, I think I get that. So it is not as much about long paths but rather paths with spaces in them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Update runant.py
Posted by vit1251 <gi...@git.apache.org>.
Github user vit1251 commented on the pull request:
https://github.com/apache/ant/pull/1#issuecomment-63275249
Magic here:
-cmdline = ('%s %s -classpath %s -Dant.home=%s %s ' + \
+cmdline = ('"%s" %s -classpath %s -Dant.home=%s %s ' + \
'org.apache.tools.ant.launch.Launcher %s %s %s') \
% (JAVACMD, ANT_OPTS, LOCALCLASSPATH, ANT_HOME, OPTS, ANT_ARGS, \
CLASSPATH, string.join(sys.argv[1:], ' '))
When JAVACMD is "C:/Program Files/Java/jre_1_7_55555/bin/java.exe" os.system is call execute file"C:/Program" but tht file is not found and it require quota.
I in my suggested patch add that quota but not tested in unix/linux ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Update runant.py
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/1#issuecomment-63274385
I'm not familiar with how Python works on Windows at all, so please bear with me. How does stripping quotes and explicitly adding them later help with long path?
Also I don't get the os.system comment - at least you didn't change any usage of os.system.
The script's author-header is another issue, we've removed all author notes as a policy from Ant's code base but obviously missed this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Update runant.py
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org