You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Akos Dombi (Jira)" <ji...@apache.org> on 2019/09/13 13:10:00 UTC
[jira] [Updated] (HIVE-22191) Simplify SemanticAnalyzer by removing
unused code
[ https://issues.apache.org/jira/browse/HIVE-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akos Dombi updated HIVE-22191:
------------------------------
Description:
Simplify {{SemanticAnalyzer}} by:
- Remove dead code
- Simplify returning statements
- Use interfaces types for parameters/fields/variables where it is straightforward to migrate
- Make visibility stricter where it is possible
- Check logging to use parametrised logging
- Removing unnecessary keywords (e.g.: {{static}})
- Some code part could be simplified by using Java 8 features
I think this is crucial step as this class already contains 15000+ lines of code which is screaming for splitting into more reasonable classes.
was:
Simplify {{SemanticAnalyzer}} by:
- Removing not used lines
- Removing unnecessary keywords (e.g.: {{static}})
- Some code part could be simplified by using Java 8 features
I think this is crucial step as this class already contains 15000+ lines of code which is screaming for splitting into more reasonable classes.
> Simplify SemanticAnalyzer by removing unused code
> -------------------------------------------------
>
> Key: HIVE-22191
> URL: https://issues.apache.org/jira/browse/HIVE-22191
> Project: Hive
> Issue Type: Task
> Components: Hive
> Reporter: Akos Dombi
> Assignee: Akos Dombi
> Priority: Major
>
> Simplify {{SemanticAnalyzer}} by:
> - Remove dead code
> - Simplify returning statements
> - Use interfaces types for parameters/fields/variables where it is straightforward to migrate
> - Make visibility stricter where it is possible
> - Check logging to use parametrised logging
> - Removing unnecessary keywords (e.g.: {{static}})
> - Some code part could be simplified by using Java 8 features
> I think this is crucial step as this class already contains 15000+ lines of code which is screaming for splitting into more reasonable classes.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)