You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/27 00:41:37 UTC

[GitHub] [flink] wsry edited a comment on pull request #13239: [FLINK-19021][network] Various cleanups and refactorings of the ResultPartition

wsry edited a comment on pull request #13239:
URL: https://github.com/apache/flink/pull/13239#issuecomment-680884418


   @StephanEwen Thanks for cleanups and refactorings. These are really nice changes. The code LGTM. Only two small questions:
   1. Should we also remove ResultPartitionWriter#getSubpartition which was also introduced by unaligned checkpoint and it may be not necessary for sorted-resultpartition to implementation it.
   2. We removed ReleaseOnConsumptionResultPartition in commit d7c17e2 ([FLINK-19045][network] Remove obsolete 'taskmanager.network.partitionforce-release-on-consumption' option.) which make the commit can not be compiled, should we remove it in commit cd03741 ([FLINK-19046][network] Introduce separate classes for ResultPartitionTypes)?
   
   Looking forward to the PR to be merged soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org