You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/14 07:23:52 UTC
[GitHub] flink pull request #4329: [FLINK-7176] [travis] Improve error handling
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4329
[FLINK-7176] [travis] Improve error handling
This PR modifies the travis scripts to
a) verify the shaded dependencies only when compilation&tests succeeded (to reduce noise)
b) not call exit when the shading was incorrect.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7176_13
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4329
----
commit a97df7efb5b52aac2e99ad5666135240d159b413
Author: zentol <ch...@apache.org>
Date: 2017-07-13T15:53:40Z
[FLINK-7176] [travis] Improve error handling
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4329: [FLINK-7176] [travis] Improve error handling
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4329#discussion_r127788859
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -225,9 +226,14 @@ echo "MVN exited with EXIT CODE: ${EXIT_CODE}."
rm $MVN_PID
rm $MVN_EXIT
-check_shaded_artifacts
-
-put_yarn_logs_to_artifacts
--- End diff --
This is removed here, is that on purpose?
Are the yarn logs now handled differently?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4329: [FLINK-7176] [travis] Improve error handling
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4329#discussion_r127794837
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -225,9 +226,14 @@ echo "MVN exited with EXIT CODE: ${EXIT_CODE}."
rm $MVN_PID
rm $MVN_EXIT
-check_shaded_artifacts
-
-put_yarn_logs_to_artifacts
--- End diff --
ohh...no that wasn't on purpose, must've happened during rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4329: [FLINK-7176] [travis] Improve error handling
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---