[jira] [Commented] (FINERACT-1152) Loan Rescheduling: Validation for End date to be on an instalment date should consider new Schedule

["Sandro Martínez Pérez (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18068216#comment-18068216 ] 

Sandro Martínez Pérez commented on FINERACT-1152:
-------------------------------------------------

Hi team, I opened [#5689|https://github.com/apache/fineract/pull/5689] and I believe it is the correct fix for this issue. However, some CI checks failed, and after a deep review I haven’t found a clear implementation issue on my side. The failures look like possible baseline/pipeline drift, but I may be missing an indirect effect.

Could someone with expertise in this area review the PR and help verify whether this is real regression vs baseline/pipeline drift? 

These are the failing checks:
 * {*}C3280 (EMI E2E){*}: expected final *_Accrual_* on 01 May 2024 = {*}15.97{*}, actual = {*}11.51{*}.
 * {*}C4580 (Charge-off E2E){*}: transaction tab row count mismatch after 2 *MERCHANT_ISSUED_REFUND* operations (expected {*}6{*}, actual {*}7{*}).
 * {*}Build/Cucumber (non-E2E){*}: CycloneDX/Maven model resolution error for SWT ({color:#FF0000}org.eclipse.swt.${osgi.platform}{color} artifactId validation), from {color:#FF0000}org.cyclonedx.gradle.MavenHelper.resolveEffectivePom{color}.

> Loan Rescheduling: Validation for End date to be on an instalment date should consider new Schedule 
> ----------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-1152
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1152
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Manoj Mohanan
>            Priority: Minor
>
> In Loan Rescheduling while changing EMI, there is a validation for the input End date  to check whether End date falls on an installment date.
> when multple rescheduling is applied together, for example : extend tenure and change EMI, the newly added installment dates cannot be given as end date, As the validation consider the current schedule for cheking the validtity of End date.
> This validation should be changed so that it should consider the future schedule ( the Schedule that is generated as result of the rescheduling) for the validation.
> or remove the validation and take the nearest installment date before  given end date as the last installment to be modified.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)