You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/09/15 15:16:35 UTC
Review Request 62357: Updated logging initialization arguments.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62357/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Alexander Rukletsov.
Bugs: MESOS-7586
https://issues.apache.org/jira/browse/MESOS-7586
Repository: mesos
Description
-------
The arguments `_flags` and `installFailureSignalHandler`
are now swapped and `installFailureSignalHandler`
does not have a default value anymore.
Diffs
-----
src/cli/execute.cpp e844fa46a43bdfb08246be929b7913a7997f18df
src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79
src/examples/balloon_framework.cpp a63dbab2b478b28738940114bd157a56b49d473b
src/examples/disk_full_framework.cpp 2572c72ded86d4befc1dc137e264dfe6ff64a357
src/examples/dynamic_reservation_framework.cpp bb6f58ba8fb87ae37d4ae971c192a204d5a656c5
src/examples/load_generator_framework.cpp 653ae815df2009613b8f89308ab1b5f19757825a
src/examples/long_lived_framework.cpp da632040ece591717a38b44158b3eedd9f0ae7c4
src/examples/no_executor_framework.cpp 2ca240b4c998f0e33e7b09dbad9f4a7bfa0583cc
src/examples/persistent_volume_framework.cpp bce2a2d1c73a3a1efab6d107529d9f6cfe9854da
src/examples/test_framework.cpp a6b38f02cc29682e3d3e1adf83baea061feda9e7
src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e
src/exec/exec.cpp 65c4575f8d44a1f4d4e99350b770eb8b921c0644
src/executor/executor.cpp 91bbd1e7651754620324e2384b7becbad9240a26
src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529
src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082
src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87
src/local/main.cpp f6145b71c7ff7b454a63fd1f1865dbf7bf7345d2
src/log/tool/benchmark.cpp 8264fdaa3316175cdb305202fd7b4968e896b968
src/log/tool/initialize.cpp 6a12505119bebd4c5cfbe00aeb45a51ad9d62bec
src/log/tool/read.cpp 7b308986012fc14d5f01c88d2d09ceb45ad5db75
src/log/tool/replica.cpp 45bd1f4bc54cf4c84af207c977fb78b23f042873
src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af
src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b
src/master/main.cpp 7e815bf89e018921757b19dc8e16e2d5139248ee
src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
src/scheduler/scheduler.cpp ce69258027ed50867569374d2d827fc3cc651744
src/slave/container_loggers/logrotate.cpp 61484b18f4615e85925b26d999afb5ac3b7e32a5
src/slave/containerizer/mesos/io/switchboard_main.cpp fa0b29667258b6b6fb7381d8226b6dda0062629e
src/slave/main.cpp d53ff5013e00421ef1e13593584bd132a59738fb
src/tests/main.cpp a7dc99b90f84a1a1ea299c937fbfc84e55adad1c
Diff: https://reviews.apache.org/r/62357/diff/1/
Testing
-------
```
make check
```
Thanks,
Armand Grillet
Re: Review Request 62357: Updated logging initialization arguments.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62357/#review185502
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62018', '62037', '62357']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62357
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62357/logs/mesos-tests-stdout.log):
```
[ RUN ] PathsTest.BootId
[ OK ] PathsTest.BootId (3 ms)
[ RUN ] PathsTest.Slave
[ OK ] PathsTest.Slave (2 ms)
[ RUN ] PathsTest.Framework
[ OK ] PathsTest.Framework (3 ms)
[ RUN ] PathsTest.Executor
[ OK ] PathsTest.Executor (3 ms)
[ RUN ] PathsTest.LibProcessPid
[ OK ] PathsTest.LibProcessPid (4 ms)
[ RUN ] PathsTest.Task
[ OK ] PathsTest.Task (3 ms)
[ RUN ] PathsTest.PersistentVolume
[ OK ] PathsTest.PersistentVolume (3 ms)
[----------] 11 tests from PathsTest (418 ms total)
[----------] 3 tests from ProtobufIOTest
[ RUN ] ProtobufIOTest.Basic
[ OK ] ProtobufIOTest.Basic (11 ms)
[ RUN ] ProtobufIOTest.Append
[ OK ] ProtobufIOTest.Append (68 ms)
[ RUN ] ProtobufIOTest.RepeatedPtrField
[ OK ] ProtobufIOTest.RepeatedPtrField (6 ms)
[----------] 3 tests from ProtobufIOTest (178 ms total)
[----------] 4 tests from ResourceOffersTest
[ RUN ] ResourceOffersTest.ResourcesGetReofferedAfterFrameworkStops
[ OK ] ResourceOffersTest.ResourcesGetReofferedAfterFrameworkStops (612 ms)
[ RUN ] ResourceOffersTest.ResourcesGetReofferedWhenUnused
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62357/logs/mesos-tests-stderr.log):
```
I0915 18:41:48.607561 18924 master.cpp:7725] Sending 1 offers to framework dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-0001 (default) at scheduler-ea572bc0-3e7d-4df2-8b08-d37365e128f7@10.3.1.5:62971
I0915 18:41:48.610555 18756 sched.cpp:2021] Asked to stop the driver
I0915 18:41:48.610555 15528 sched.cpp:1203] Stopping framework dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-0001
I0915 18:41:48.611560 19024 master.cpp:8406] Processing TEARDOWN call for framework dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-0001 (default) at scheduler-ea572bc0-3e7d-4df2-8b08-d37365e128f7@10.3.1.5:62971
I0915 18:41:48.612556 19024 master.cpp:8418] Removing framework dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-0001 (default) at scheduler-ea572bc0-3e7d-4df2-8b08-d37365e128f7@10.3.1.5:62971
I0915 18:41:48.612556 19024 master.cpp:3267] Deactivating framework dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-0001 (default) at scheduler-ea572bc0-3e7d-4df2-8b08-d37365e128f7@10.3.1.5:62971
I0915 18:41:48.622561 18756 slave.cpp:861] Agent terminating
I0915 18:41:48.623555 18924 hierarchical.cpp:412] Deactivated framework dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-0001
I0915 18:41:48.624555 19024 master.cpp:9225] Removing offer dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-O1
I0915 18:41:48.626555 19024 master.cpp:1321] Agent dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-S0 at slave(70)@10.3.1.5:62971 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0915 18:41:48.626555 19024 master.cpp:3304] Disconnecting agent dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-S0 at slave(70)@10.3.1.5:62971 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0915 18:41:48.627555 19024 master.cpp:3323] Deactivating agent dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-S0 at slave(70)@10.3.1.5:62971 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0915 18:41:48.631556 18924 hierarchical.cpp:355] Removed framework dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-0001
I0915 18:41:48.641557 18924 hierarchical.cpp:690] Agent dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-S0 deactivated
I0915 18:41:48.667559 17808 master.cpp:1163] Master terminating
I0915 18:41:48.673557 18924 hierarchical.cpp:626] Removed agent dd01969d-8c17-4d48-9bcc-b73e47e2e1b0-S0
I0915 18:41:48.756562 18756 cluster.cpp:162] Creating default 'local' authorizer
I0915 18:41:48.784561 19024 master.cpp:445] Master b95b7bc0-4395-464f-8557-64911296c595 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 10.3.1.5:62971
I0915 18:41:48.784561 19024 master.cpp:447] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF" --authenticate_agents="false" --authenticate_frameworks="false" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5" --authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\2\jBXCGw\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_mem
ory" --registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --root_submissions="true" --user_sorter="drf" --version="false" --webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\2\jBXCGw\master" --zk_session_timeout="10secs"
I0915 18:41:48.797562 19024 master.cpp:524] Master only allowing authenticated HTTP frameworks to register
I0915 18:41:48.808585 19024 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\jBXCGw\credentials'
I0915 18:41:48.811671 19024 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I0915 18:41:48.812564 19024 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I0915 18:41:48.812564 19024 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I0915 18:41:48.813565 19024 master.cpp:649] Authorization enabled
I0915 18:41:48.844568 19100 master.cpp:2166] Elected as the leading master!
I0915 18:41:48.844568 19100 master.cpp:1705] Recovering from registrar
I0915 18:41:48.846570 15528 registrar.cpp:391] Successfully fetched the registry (0B) in 996864ns
I0915 18:41:48.847573 15528 registrar.cpp:495] Applied 1 operations in 0ns; attempting to update the registry
I0915 18:41:48.849566 18576 registrar.cpp:5```
- Mesos Reviewbot Windows
On Sept. 15, 2017, 3:16 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62357/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
>
>
> Bugs: MESOS-7586
> https://issues.apache.org/jira/browse/MESOS-7586
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The arguments `_flags` and `installFailureSignalHandler`
> are now swapped and `installFailureSignalHandler`
> does not have a default value anymore.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp e844fa46a43bdfb08246be929b7913a7997f18df
> src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79
> src/examples/balloon_framework.cpp a63dbab2b478b28738940114bd157a56b49d473b
> src/examples/disk_full_framework.cpp 2572c72ded86d4befc1dc137e264dfe6ff64a357
> src/examples/dynamic_reservation_framework.cpp bb6f58ba8fb87ae37d4ae971c192a204d5a656c5
> src/examples/load_generator_framework.cpp 653ae815df2009613b8f89308ab1b5f19757825a
> src/examples/long_lived_framework.cpp da632040ece591717a38b44158b3eedd9f0ae7c4
> src/examples/no_executor_framework.cpp 2ca240b4c998f0e33e7b09dbad9f4a7bfa0583cc
> src/examples/persistent_volume_framework.cpp bce2a2d1c73a3a1efab6d107529d9f6cfe9854da
> src/examples/test_framework.cpp a6b38f02cc29682e3d3e1adf83baea061feda9e7
> src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e
> src/exec/exec.cpp 65c4575f8d44a1f4d4e99350b770eb8b921c0644
> src/executor/executor.cpp 91bbd1e7651754620324e2384b7becbad9240a26
> src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529
> src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082
> src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87
> src/local/main.cpp f6145b71c7ff7b454a63fd1f1865dbf7bf7345d2
> src/log/tool/benchmark.cpp 8264fdaa3316175cdb305202fd7b4968e896b968
> src/log/tool/initialize.cpp 6a12505119bebd4c5cfbe00aeb45a51ad9d62bec
> src/log/tool/read.cpp 7b308986012fc14d5f01c88d2d09ceb45ad5db75
> src/log/tool/replica.cpp 45bd1f4bc54cf4c84af207c977fb78b23f042873
> src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af
> src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b
> src/master/main.cpp 7e815bf89e018921757b19dc8e16e2d5139248ee
> src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
> src/scheduler/scheduler.cpp ce69258027ed50867569374d2d827fc3cc651744
> src/slave/container_loggers/logrotate.cpp 61484b18f4615e85925b26d999afb5ac3b7e32a5
> src/slave/containerizer/mesos/io/switchboard_main.cpp fa0b29667258b6b6fb7381d8226b6dda0062629e
> src/slave/main.cpp d53ff5013e00421ef1e13593584bd132a59738fb
> src/tests/main.cpp a7dc99b90f84a1a1ea299c937fbfc84e55adad1c
>
>
> Diff: https://reviews.apache.org/r/62357/diff/1/
>
>
> Testing
> -------
>
> ```
> make check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62357: Updated logging initialization arguments.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62357/#review185609
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Sept. 18, 2017, 6:33 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62357/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2017, 6:33 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
>
>
> Bugs: MESOS-7586
> https://issues.apache.org/jira/browse/MESOS-7586
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The arguments `flags` and `installFailureSignalHandler` are now
> swapped and `flags` is optional. The will allow the logging
> initialization to be more broadly used in a future patch.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79
> src/examples/load_generator_framework.cpp 653ae815df2009613b8f89308ab1b5f19757825a
> src/examples/no_executor_framework.cpp 2ca240b4c998f0e33e7b09dbad9f4a7bfa0583cc
> src/examples/persistent_volume_framework.cpp bce2a2d1c73a3a1efab6d107529d9f6cfe9854da
> src/examples/test_framework.cpp a6b38f02cc29682e3d3e1adf83baea061feda9e7
> src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e
> src/exec/exec.cpp 65c4575f8d44a1f4d4e99350b770eb8b921c0644
> src/executor/executor.cpp 91bbd1e7651754620324e2384b7becbad9240a26
> src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529
> src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082
> src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87
> src/local/main.cpp f6145b71c7ff7b454a63fd1f1865dbf7bf7345d2
> src/log/tool/benchmark.cpp 8264fdaa3316175cdb305202fd7b4968e896b968
> src/log/tool/initialize.cpp 6a12505119bebd4c5cfbe00aeb45a51ad9d62bec
> src/log/tool/read.cpp 7b308986012fc14d5f01c88d2d09ceb45ad5db75
> src/log/tool/replica.cpp 45bd1f4bc54cf4c84af207c977fb78b23f042873
> src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af
> src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b
> src/master/main.cpp 7e815bf89e018921757b19dc8e16e2d5139248ee
> src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
> src/scheduler/scheduler.cpp ce69258027ed50867569374d2d827fc3cc651744
> src/slave/main.cpp d53ff5013e00421ef1e13593584bd132a59738fb
> src/tests/main.cpp a7dc99b90f84a1a1ea299c937fbfc84e55adad1c
>
>
> Diff: https://reviews.apache.org/r/62357/diff/2/
>
>
> Testing
> -------
>
> ```
> make check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62357: Updated logging initialization arguments.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62357/
-----------------------------------------------------------
(Updated Sept. 18, 2017, 6:33 p.m.)
Review request for mesos, Andrei Budnik and Alexander Rukletsov.
Bugs: MESOS-7586
https://issues.apache.org/jira/browse/MESOS-7586
Repository: mesos
Description
-------
The arguments `flags` and `installFailureSignalHandler` are now
swapped and `flags` is optional. The will allow the logging
initialization to be more broadly used in a future patch.
Diffs
-----
src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79
src/examples/load_generator_framework.cpp 653ae815df2009613b8f89308ab1b5f19757825a
src/examples/no_executor_framework.cpp 2ca240b4c998f0e33e7b09dbad9f4a7bfa0583cc
src/examples/persistent_volume_framework.cpp bce2a2d1c73a3a1efab6d107529d9f6cfe9854da
src/examples/test_framework.cpp a6b38f02cc29682e3d3e1adf83baea061feda9e7
src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e
src/exec/exec.cpp 65c4575f8d44a1f4d4e99350b770eb8b921c0644
src/executor/executor.cpp 91bbd1e7651754620324e2384b7becbad9240a26
src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529
src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082
src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87
src/local/main.cpp f6145b71c7ff7b454a63fd1f1865dbf7bf7345d2
src/log/tool/benchmark.cpp 8264fdaa3316175cdb305202fd7b4968e896b968
src/log/tool/initialize.cpp 6a12505119bebd4c5cfbe00aeb45a51ad9d62bec
src/log/tool/read.cpp 7b308986012fc14d5f01c88d2d09ceb45ad5db75
src/log/tool/replica.cpp 45bd1f4bc54cf4c84af207c977fb78b23f042873
src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af
src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b
src/master/main.cpp 7e815bf89e018921757b19dc8e16e2d5139248ee
src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
src/scheduler/scheduler.cpp ce69258027ed50867569374d2d827fc3cc651744
src/slave/main.cpp d53ff5013e00421ef1e13593584bd132a59738fb
src/tests/main.cpp a7dc99b90f84a1a1ea299c937fbfc84e55adad1c
Diff: https://reviews.apache.org/r/62357/diff/2/
Testing
-------
```
make check
```
Thanks,
Armand Grillet
Re: Review Request 62357: Updated logging initialization arguments.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62357/#review185564
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Budnik
On Sept. 18, 2017, 2:24 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62357/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2017, 2:24 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
>
>
> Bugs: MESOS-7586
> https://issues.apache.org/jira/browse/MESOS-7586
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The arguments `flags` and `installFailureSignalHandler` are now
> swapped and `flags` is optional. The will allow the logging
> initialization to be more broadly used in a future patch.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79
> src/examples/load_generator_framework.cpp 653ae815df2009613b8f89308ab1b5f19757825a
> src/examples/no_executor_framework.cpp 2ca240b4c998f0e33e7b09dbad9f4a7bfa0583cc
> src/examples/persistent_volume_framework.cpp bce2a2d1c73a3a1efab6d107529d9f6cfe9854da
> src/examples/test_framework.cpp a6b38f02cc29682e3d3e1adf83baea061feda9e7
> src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e
> src/exec/exec.cpp 65c4575f8d44a1f4d4e99350b770eb8b921c0644
> src/executor/executor.cpp 91bbd1e7651754620324e2384b7becbad9240a26
> src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529
> src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082
> src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87
> src/local/main.cpp f6145b71c7ff7b454a63fd1f1865dbf7bf7345d2
> src/log/tool/benchmark.cpp 8264fdaa3316175cdb305202fd7b4968e896b968
> src/log/tool/initialize.cpp 6a12505119bebd4c5cfbe00aeb45a51ad9d62bec
> src/log/tool/read.cpp 7b308986012fc14d5f01c88d2d09ceb45ad5db75
> src/log/tool/replica.cpp 45bd1f4bc54cf4c84af207c977fb78b23f042873
> src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af
> src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b
> src/master/main.cpp 7e815bf89e018921757b19dc8e16e2d5139248ee
> src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
> src/scheduler/scheduler.cpp ce69258027ed50867569374d2d827fc3cc651744
> src/slave/main.cpp d53ff5013e00421ef1e13593584bd132a59738fb
> src/tests/main.cpp a7dc99b90f84a1a1ea299c937fbfc84e55adad1c
>
>
> Diff: https://reviews.apache.org/r/62357/diff/2/
>
>
> Testing
> -------
>
> ```
> make check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62357: Updated logging initialization arguments.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62357/
-----------------------------------------------------------
(Updated Sept. 18, 2017, 2:24 p.m.)
Review request for mesos, Andrei Budnik and Alexander Rukletsov.
Changes
-------
Updated patch to be a combination of /r/62018 and /r/62357.
Bugs: MESOS-7586
https://issues.apache.org/jira/browse/MESOS-7586
Repository: mesos
Description (updated)
-------
The arguments `flags` and `installFailureSignalHandler` are now
swapped and `flags` is optional. The will allow the logging
initialization to be more broadly used in a future patch.
Diffs (updated)
-----
src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79
src/examples/load_generator_framework.cpp 653ae815df2009613b8f89308ab1b5f19757825a
src/examples/no_executor_framework.cpp 2ca240b4c998f0e33e7b09dbad9f4a7bfa0583cc
src/examples/persistent_volume_framework.cpp bce2a2d1c73a3a1efab6d107529d9f6cfe9854da
src/examples/test_framework.cpp a6b38f02cc29682e3d3e1adf83baea061feda9e7
src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e
src/exec/exec.cpp 65c4575f8d44a1f4d4e99350b770eb8b921c0644
src/executor/executor.cpp 91bbd1e7651754620324e2384b7becbad9240a26
src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529
src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082
src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87
src/local/main.cpp f6145b71c7ff7b454a63fd1f1865dbf7bf7345d2
src/log/tool/benchmark.cpp 8264fdaa3316175cdb305202fd7b4968e896b968
src/log/tool/initialize.cpp 6a12505119bebd4c5cfbe00aeb45a51ad9d62bec
src/log/tool/read.cpp 7b308986012fc14d5f01c88d2d09ceb45ad5db75
src/log/tool/replica.cpp 45bd1f4bc54cf4c84af207c977fb78b23f042873
src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af
src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b
src/master/main.cpp 7e815bf89e018921757b19dc8e16e2d5139248ee
src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
src/scheduler/scheduler.cpp ce69258027ed50867569374d2d827fc3cc651744
src/slave/main.cpp d53ff5013e00421ef1e13593584bd132a59738fb
src/tests/main.cpp a7dc99b90f84a1a1ea299c937fbfc84e55adad1c
Diff: https://reviews.apache.org/r/62357/diff/2/
Changes: https://reviews.apache.org/r/62357/diff/1-2/
Testing
-------
```
make check
```
Thanks,
Armand Grillet