You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@continuum.apache.org by Brett Porter <br...@apache.org> on 2008/06/26 12:34:01 UTC
Re: svn commit: r671847 - /continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
On 26/06/2008, at 6:28 PM, evenisse@apache.org wrote:
> Author: evenisse
> Date: Thu Jun 26 03:28:56 2008
> New Revision: 671847
>
> URL: http://svn.apache.org/viewvc?rev=671847&view=rev
> Log:
> Restore forced build feature
>
> Modified:
> continuum/trunk/continuum-core/src/main/java/org/apache/maven/
> continuum/buildcontroller/DefaultBuildController.java
>
> Modified: continuum/trunk/continuum-core/src/main/java/org/apache/
> maven/continuum/buildcontroller/DefaultBuildController.java
> URL: http://svn.apache.org/viewvc/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java?rev=671847&r1=671846&r2=671847&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- continuum/trunk/continuum-core/src/main/java/org/apache/maven/
> continuum/buildcontroller/DefaultBuildController.java (original)
> +++ continuum/trunk/continuum-core/src/main/java/org/apache/maven/
> continuum/buildcontroller/DefaultBuildController.java Thu Jun 26
> 03:28:56 2008
> @@ -482,6 +482,12 @@
> return true;
> }
>
> + if ( context.getTrigger() !=
> ContinuumProjectState.TRIGGER_FORCED )
> + {
> + getLogger().info( "The project build is forced,
> building" );
> + return true
missing ; ?
>
> + }
> +
> boolean shouldBuild = false;
>
> boolean allChangesUnknown = true;
>
>
--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/
Re: svn commit: r671847 - /continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
Posted by Brett Porter <br...@apache.org>.
Cool, I'm really looking forward to trying this out now. It might
reclaim us a lot of cycles on vmbuild!
On 27/06/2008, at 12:39 AM, Olivier Lamy wrote:
> Yes.
> Thanks !
> --
> Olivier
>
> 2008/6/26 Emmanuel Venisse <em...@gmail.com>:
>> It should be fixed now.
>>
>> Emmanuel
>>
>> On Thu, Jun 26, 2008 at 3:26 PM, Emmanuel Venisse <
>> emmanuel.venisse@gmail.com> wrote:
>>
>>> okok, I look at it now to fix it definitively.
>>>
>>>
>>> On Thu, Jun 26, 2008 at 3:13 PM, Olivier Lamy <ol...@apache.org>
>>> wrote:
>>>
>>>> Weird because the build has failed in vmbuild and I haven't
>>>> received any
>>>> mail.
>>>>
>>>> But continuum-core has a unit failure, try with mvn test
>>>> -Dtest=DefaultBuildControllerTest -DfailIfNoTests=false
>>>> -Dsurefire.useFile=false.
>>>>
>>>> --
>>>> Olivier
>>>>
>>>> 2008/6/26 Brett Porter <br...@apache.org>:
>>>>>
>>>>> On 26/06/2008, at 8:25 PM, Emmanuel Venisse wrote:
>>>>>
>>>>>>>
>>>>>>> missing ; ?
>>>>>>>
>>>>>>
>>>>>> Fixed. I need to change my hands or maybe holidays :)
>>>>>
>>>>> Maybe you just like our continuous integration server to pick up
>>>>> compile
>>>>> errors so we can see it working :D
>>>>>
>>>>> - Brett
>>>>>
>>>>> --
>>>>> Brett Porter
>>>>> brett@apache.org
>>>>> http://blogs.exist.com/bporter/
>>>>>
>>>>>
>>>>
>>>
>>>
>>
--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/
Re: svn commit: r671847 - /continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
Posted by Olivier Lamy <ol...@apache.org>.
Yes.
Thanks !
--
Olivier
2008/6/26 Emmanuel Venisse <em...@gmail.com>:
> It should be fixed now.
>
> Emmanuel
>
> On Thu, Jun 26, 2008 at 3:26 PM, Emmanuel Venisse <
> emmanuel.venisse@gmail.com> wrote:
>
>> okok, I look at it now to fix it definitively.
>>
>>
>> On Thu, Jun 26, 2008 at 3:13 PM, Olivier Lamy <ol...@apache.org> wrote:
>>
>>> Weird because the build has failed in vmbuild and I haven't received any
>>> mail.
>>>
>>> But continuum-core has a unit failure, try with mvn test
>>> -Dtest=DefaultBuildControllerTest -DfailIfNoTests=false
>>> -Dsurefire.useFile=false.
>>>
>>> --
>>> Olivier
>>>
>>> 2008/6/26 Brett Porter <br...@apache.org>:
>>> >
>>> > On 26/06/2008, at 8:25 PM, Emmanuel Venisse wrote:
>>> >
>>> >>>
>>> >>> missing ; ?
>>> >>>
>>> >>
>>> >> Fixed. I need to change my hands or maybe holidays :)
>>> >
>>> > Maybe you just like our continuous integration server to pick up compile
>>> > errors so we can see it working :D
>>> >
>>> > - Brett
>>> >
>>> > --
>>> > Brett Porter
>>> > brett@apache.org
>>> > http://blogs.exist.com/bporter/
>>> >
>>> >
>>>
>>
>>
>
Re: svn commit: r671847 - /continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
Posted by Emmanuel Venisse <em...@gmail.com>.
It should be fixed now.
Emmanuel
On Thu, Jun 26, 2008 at 3:26 PM, Emmanuel Venisse <
emmanuel.venisse@gmail.com> wrote:
> okok, I look at it now to fix it definitively.
>
>
> On Thu, Jun 26, 2008 at 3:13 PM, Olivier Lamy <ol...@apache.org> wrote:
>
>> Weird because the build has failed in vmbuild and I haven't received any
>> mail.
>>
>> But continuum-core has a unit failure, try with mvn test
>> -Dtest=DefaultBuildControllerTest -DfailIfNoTests=false
>> -Dsurefire.useFile=false.
>>
>> --
>> Olivier
>>
>> 2008/6/26 Brett Porter <br...@apache.org>:
>> >
>> > On 26/06/2008, at 8:25 PM, Emmanuel Venisse wrote:
>> >
>> >>>
>> >>> missing ; ?
>> >>>
>> >>
>> >> Fixed. I need to change my hands or maybe holidays :)
>> >
>> > Maybe you just like our continuous integration server to pick up compile
>> > errors so we can see it working :D
>> >
>> > - Brett
>> >
>> > --
>> > Brett Porter
>> > brett@apache.org
>> > http://blogs.exist.com/bporter/
>> >
>> >
>>
>
>
Re: svn commit: r671847 - /continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
Posted by Emmanuel Venisse <em...@gmail.com>.
okok, I look at it now to fix it definitively.
On Thu, Jun 26, 2008 at 3:13 PM, Olivier Lamy <ol...@apache.org> wrote:
> Weird because the build has failed in vmbuild and I haven't received any
> mail.
>
> But continuum-core has a unit failure, try with mvn test
> -Dtest=DefaultBuildControllerTest -DfailIfNoTests=false
> -Dsurefire.useFile=false.
>
> --
> Olivier
>
> 2008/6/26 Brett Porter <br...@apache.org>:
> >
> > On 26/06/2008, at 8:25 PM, Emmanuel Venisse wrote:
> >
> >>>
> >>> missing ; ?
> >>>
> >>
> >> Fixed. I need to change my hands or maybe holidays :)
> >
> > Maybe you just like our continuous integration server to pick up compile
> > errors so we can see it working :D
> >
> > - Brett
> >
> > --
> > Brett Porter
> > brett@apache.org
> > http://blogs.exist.com/bporter/
> >
> >
>
Re: svn commit: r671847 - /continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
Posted by Olivier Lamy <ol...@apache.org>.
Weird because the build has failed in vmbuild and I haven't received any mail.
But continuum-core has a unit failure, try with mvn test
-Dtest=DefaultBuildControllerTest -DfailIfNoTests=false
-Dsurefire.useFile=false.
--
Olivier
2008/6/26 Brett Porter <br...@apache.org>:
>
> On 26/06/2008, at 8:25 PM, Emmanuel Venisse wrote:
>
>>>
>>> missing ; ?
>>>
>>
>> Fixed. I need to change my hands or maybe holidays :)
>
> Maybe you just like our continuous integration server to pick up compile
> errors so we can see it working :D
>
> - Brett
>
> --
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>
Re: svn commit: r671847 - /continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
Posted by Brett Porter <br...@apache.org>.
On 26/06/2008, at 8:25 PM, Emmanuel Venisse wrote:
>>
>> missing ; ?
>>
>
> Fixed. I need to change my hands or maybe holidays :)
Maybe you just like our continuous integration server to pick up
compile errors so we can see it working :D
- Brett
--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/
Re: svn commit: r671847 - /continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
Posted by Emmanuel Venisse <em...@gmail.com>.
On Thu, Jun 26, 2008 at 12:34 PM, Brett Porter <br...@apache.org> wrote:
>
> On 26/06/2008, at 6:28 PM, evenisse@apache.org wrote:
>
> Author: evenisse
>> Date: Thu Jun 26 03:28:56 2008
>> New Revision: 671847
>>
>> URL: http://svn.apache.org/viewvc?rev=671847&view=rev
>> Log:
>> Restore forced build feature
>>
>> Modified:
>>
>> continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
>>
>> Modified:
>> continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
>> URL:
>> http://svn.apache.org/viewvc/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java?rev=671847&r1=671846&r2=671847&view=diff
>>
>> ==============================================================================
>> ---
>> continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
>> (original)
>> +++
>> continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
>> Thu Jun 26 03:28:56 2008
>> @@ -482,6 +482,12 @@
>> return true;
>> }
>>
>> + if ( context.getTrigger() != ContinuumProjectState.TRIGGER_FORCED
>> )
>> + {
>> + getLogger().info( "The project build is forced, building" );
>> + return true
>>
>
> missing ; ?
>
Fixed. I need to change my hands or maybe holidays :)
Emmanuel
>
>
>
>> + }
>> +
>> boolean shouldBuild = false;
>>
>> boolean allChangesUnknown = true;
>>
>>
>>
> --
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>