[jira] [Updated] (HDFS-11972) CBlocks use wrong OPT env vars

["Anu Engineer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-11972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anu Engineer updated HDFS-11972:
--------------------------------
          Resolution: Fixed
        Hadoop Flags: Reviewed
       Fix Version/s: HDFS-7240
    Target Version/s: HDFS-7240
              Status: Resolved  (was: Patch Available)

[~msingh] Thank you for the contribution. I have committed this to the feature branch. 
[~aw] Thanks for flagging this issue.


> CBlocks use wrong OPT env vars
> ------------------------------
>
>                 Key: HDFS-11972
>                 URL: https://issues.apache.org/jira/browse/HDFS-11972
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs
>            Reporter: Allen Wittenauer
>            Assignee: Mukul Kumar Singh
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-11972-HDFS-7240.001.patch
>
>
> Current codebase does:
> {code}
>       hadoop_debug "Appending HADOOP_CBLOCK_OPTS onto HADOOP_OPTS" 
>       HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_CBLOCK_OPTS}"
> ...  
>       hadoop_debug "Appending HADOOP_JSCSI_OPTS onto HADOOP_OPTS"
>       HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_JSCSI_OPTS}"
> {code}
> This code block breaks the consistency with the rest of the shell scripts:
> a) It should be HDFS_CBLOCKSERVER_OPTS, HDFS_JSCSI_OPTS
> b) _OPTS, unless they are a deprecated form or some other special case, are already/automatically appended; there is no need to do them specifically
> Also, a description of these env vars should be hadoop-env.sh for documentation purposes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org