You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Aleksandar Vidakovic (Jira)" <ji...@apache.org> on 2020/10/20 20:29:00 UTC

[jira] [Commented] (FINERACT-1231) SDK Swagger Java Client generated utilities are broken and should be removed from JAR

    [ https://issues.apache.org/jira/browse/FINERACT-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217913#comment-17217913 ] 

Aleksandar Vidakovic commented on FINERACT-1231:
------------------------------------------------

[~vorburger] not sure if that helps with what you intend to do: but in some of my projects I just disable the whole invoker generation stuff (possible with a simple flag). Never found the code that useful... and in the case of JSON it hides those various Date adapters for GSON where I'd prefer to just have them in a package (but maybe that's just me). Overall everything that falls under the "invoker" category is pretty much static code... there's nothing (I think) that depends on any changes in fineract.yaml. So... I would just keep the useful stuff and check it in under fineract-client/src/main/java ... and toss the rest (with that flag).

> SDK Swagger Java Client generated utilities are broken and should be removed from JAR
> -------------------------------------------------------------------------------------
>
>                 Key: FINERACT-1231
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1231
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Michael Vorburger
>            Priority: Major
>
> While working on FINERACT-1220, I'm finding that the Swagger Code generated {{org.apache.fineract.client.ApiClient}} and {{org.apache.fineract.client.JSON}} are broken. I'm going to write code replacing them as part of (my, hand written) {{/fineract-client/src/main/java/org/apache/fineract/client/util/FineractClient.java}} (which is already on develop).
> To avoid confusion to future users, [~aleks] what's the best way in Gradle to simply entirely wipe out all 6 classes in {{fineract-client/build/generated/java/src/main/java/org/apache/fineract/client}} progrmatically just after they were generated - can you help me with a PR for that? (Once FINERACT-1220 is completed.)
> Maybe its easier to change that {{invokerPackage}} in {{build.gradle}} to "tmp.wipe" ? :D
> Then we could probably just move (my) {{org.apache.fineract.client.util}} up to {{org.apache.fineract.client}}.
> /Cc [~ptuomola] FYI



--
This message was sent by Atlassian Jira
(v8.3.4#803005)