You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/06 14:14:50 UTC
Review Request 68229: Removed unused local variable in `slave.cpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68229/
-----------------------------------------------------------
Review request for mesos and Alexander Rojas.
Repository: mesos
Description
-------
Removed the computation of `subject` in function
`Slave::authorizeSandboxAccess` since it was unused since the
introduction of ObjectApprovers in commit 83dd7f8724.
Diffs
-----
src/slave/slave.cpp e574c249f81e0e77abe982c126fe210a6ee8b591
Diff: https://reviews.apache.org/r/68229/diff/1/
Testing
-------
`make check`
Thanks,
Benno Evers
Re: Review Request 68229: Removed unused local variable in
`slave.cpp`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68229/#review206937
-----------------------------------------------------------
PASS: Mesos patch 68229 was successfully built and tested.
Reviews applied: `['68229']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2111/mesos-review-68229
- Mesos Reviewbot Windows
On Aug. 7, 2018, 9:36 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68229/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 9:36 a.m.)
>
>
> Review request for mesos and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed the computation of `subject` in function
> `Slave::authorizeSandboxAccess` since it was unused since the
> introduction of ObjectApprovers in commit 83dd7f8724.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e574c249f81e0e77abe982c126fe210a6ee8b591
>
>
> Diff: https://reviews.apache.org/r/68229/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68229: Removed unused local variable in
`slave.cpp`.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68229/
-----------------------------------------------------------
(Updated Aug. 7, 2018, 9:36 a.m.)
Review request for mesos and Alexander Rojas.
Repository: mesos
Description
-------
Removed the computation of `subject` in function
`Slave::authorizeSandboxAccess` since it was unused since the
introduction of ObjectApprovers in commit 83dd7f8724.
Diffs
-----
src/slave/slave.cpp e574c249f81e0e77abe982c126fe210a6ee8b591
Diff: https://reviews.apache.org/r/68229/diff/1/
Testing
-------
`make check`
Thanks,
Benno Evers
Re: Review Request 68229: Removed unused local variable in
`slave.cpp`.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68229/#review206882
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Aug. 6, 2018, 4:14 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68229/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2018, 4:14 p.m.)
>
>
> Review request for mesos and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed the computation of `subject` in function
> `Slave::authorizeSandboxAccess` since it was unused since the
> introduction of ObjectApprovers in commit 83dd7f8724.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e574c249f81e0e77abe982c126fe210a6ee8b591
>
>
> Diff: https://reviews.apache.org/r/68229/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>