You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by su...@apache.org on 2018/06/25 15:38:38 UTC

[incubator-echarts] 01/03: tweak.

This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit a7dd06ab6b7be5f808bde41df082a707ed8bce27
Author: sushuang <su...@gmail.com>
AuthorDate: Wed Jun 20 22:17:22 2018 +0800

    tweak.
---
 src/chart/custom.js                | 5 ++++-
 src/component/brush/brushAction.js | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/chart/custom.js b/src/chart/custom.js
index b665903..ae15147 100644
--- a/src/chart/custom.js
+++ b/src/chart/custom.js
@@ -335,6 +335,9 @@ function makeRenderItem(customSeries, data, ecModel, api) {
     }, prepareResult.api || {});
 
     var userParams = {
+        // The life cycle of context: current round of rendering.
+        // The global life cycle is probably not necessary, because
+        // user can store global status by themselves.
         context: {},
         seriesId: customSeries.id,
         seriesName: customSeries.name,
@@ -582,7 +585,7 @@ function mergeChildren(el, dataIndex, elOption, animatableModel, data) {
     var notMerge = mergeChildren === false;
 
     // For better performance on roam update, only enter if necessary.
-    if (!newChildren.length && !byName && !notMerge) {
+    if (!newLen && !byName && !notMerge) {
         return;
     }
 
diff --git a/src/component/brush/brushAction.js b/src/component/brush/brushAction.js
index 1e5f160..b784bd5 100644
--- a/src/component/brush/brushAction.js
+++ b/src/component/brush/brushAction.js
@@ -58,6 +58,6 @@ echarts.registerAction(
  * }
  */
 echarts.registerAction(
-        {type: 'brushSelect', event: 'brushSelected', update: 'none'},
+    {type: 'brushSelect', event: 'brushSelected', update: 'none'},
     function () {}
 );
\ No newline at end of file


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org