You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/07/21 10:03:33 UTC
Review Request 36631: LENS-679 : Use slf4j in api, regression,
ml and client modules
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36631/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-679
https://issues.apache.org/jira/browse/LENS-679
Repository: lens
Description
-------
Checked for log4j and commons logging in the modules through git grep and updated all usage to Slf4j.
Diffs
-----
lens-client/src/main/java/org/apache/lens/client/LensClient.java b15b024
lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java 14a0690
lens-client/src/main/java/org/apache/lens/client/LensConnection.java 61e16f7
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java b4e0552
lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java c68dd12
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/BaseSparkAlgo.java 86cab38
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/ColumnFeatureFunction.java d75efc0
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/HiveTableRDD.java 4960e1e
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/SparkMLDriver.java 21ed87d
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/TableTrainingSpec.java 897aacb
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/HiveMLUDF.java 60a4008
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLRunner.java e5ec272
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLTask.java 2867b90
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/ModelLoader.java c0e7953
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/TableTestingSpec.java 34b2a3f
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceImpl.java de9c711
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 77a6c40
lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java fc4164f
lens-ml-lib/src/test/java/org/apache/lens/ml/ExampleUtils.java 9fe1ea0
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 7f6413b
lens-regression/pom.xml 66ddbb0
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java ad67d7d
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java 7fd3c47
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 5d58ef2
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java 2aecbfd
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java ca59e3e
lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java abcea2b
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 5db4fa6
lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 595ef67
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java c3fe8eb
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java 5b6ec3b
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 71a37f0
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 3e7de17
Diff: https://reviews.apache.org/r/36631/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.898s]
[INFO] Lens .............................................. SUCCESS [2.914s]
[INFO] Lens API .......................................... SUCCESS [22.436s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.394s]
[INFO] Lens Cube ......................................... SUCCESS [4:29.612s]
[INFO] Lens DB storage ................................... SUCCESS [20.075s]
[INFO] Lens Query Library ................................ SUCCESS [15.299s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:48.536s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.498s]
[INFO] Lens Server ....................................... SUCCESS [5:43.152s]
[INFO] Lens client ....................................... SUCCESS [34.075s]
[INFO] Lens CLI .......................................... SUCCESS [2:37.200s]
[INFO] Lens Examples ..................................... SUCCESS [8.672s]
[INFO] Lens Distribution ................................. SUCCESS [7.976s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.728s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.667s]
[INFO] Lens Regression ................................... SUCCESS [9.617s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:54.592s
[INFO] Finished at: Tue Jul 21 07:47:47 UTC 2015
[INFO] Final Memory: 176M/1297M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 36631: LENS-679 : Use slf4j in api, regression,
ml and client modules
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36631/#review92383
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On July 21, 2015, 1:33 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36631/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 1:33 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-679
> https://issues.apache.org/jira/browse/LENS-679
>
>
> Repository: lens
>
>
> Description
> -------
>
> Checked for log4j and commons logging in the modules through git grep and updated all usage to Slf4j.
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClient.java b15b024
> lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java 14a0690
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java 61e16f7
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java b4e0552
> lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java c68dd12
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/BaseSparkAlgo.java 86cab38
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/ColumnFeatureFunction.java d75efc0
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/HiveTableRDD.java 4960e1e
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/SparkMLDriver.java 21ed87d
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/TableTrainingSpec.java 897aacb
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/HiveMLUDF.java 60a4008
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLRunner.java e5ec272
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLTask.java 2867b90
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/ModelLoader.java c0e7953
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/TableTestingSpec.java 34b2a3f
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceImpl.java de9c711
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 77a6c40
> lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java fc4164f
> lens-ml-lib/src/test/java/org/apache/lens/ml/ExampleUtils.java 9fe1ea0
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 7f6413b
> lens-regression/pom.xml 66ddbb0
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java ad67d7d
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java 7fd3c47
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 5d58ef2
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java 2aecbfd
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java ca59e3e
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java abcea2b
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 5db4fa6
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 595ef67
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java c3fe8eb
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java 5b6ec3b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 71a37f0
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 3e7de17
>
> Diff: https://reviews.apache.org/r/36631/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.898s]
> [INFO] Lens .............................................. SUCCESS [2.914s]
> [INFO] Lens API .......................................... SUCCESS [22.436s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.394s]
> [INFO] Lens Cube ......................................... SUCCESS [4:29.612s]
> [INFO] Lens DB storage ................................... SUCCESS [20.075s]
> [INFO] Lens Query Library ................................ SUCCESS [15.299s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.536s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.498s]
> [INFO] Lens Server ....................................... SUCCESS [5:43.152s]
> [INFO] Lens client ....................................... SUCCESS [34.075s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.200s]
> [INFO] Lens Examples ..................................... SUCCESS [8.672s]
> [INFO] Lens Distribution ................................. SUCCESS [7.976s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.728s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.667s]
> [INFO] Lens Regression ................................... SUCCESS [9.617s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:54.592s
> [INFO] Finished at: Tue Jul 21 07:47:47 UTC 2015
> [INFO] Final Memory: 176M/1297M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36631: LENS-679 : Use slf4j in api, regression,
ml and client modules
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36631/#review92387
-----------------------------------------------------------
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java (line 725)
<https://reviews.apache.org/r/36631/#comment146532>
Can we move this log before Thread.sleep(1000)?
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java (line 126)
<https://reviews.apache.org/r/36631/#comment146533>
Can we rewrite the log with proper explanation and with placeholders?
- Raju Bairishetti
On July 21, 2015, 8:03 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36631/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 8:03 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-679
> https://issues.apache.org/jira/browse/LENS-679
>
>
> Repository: lens
>
>
> Description
> -------
>
> Checked for log4j and commons logging in the modules through git grep and updated all usage to Slf4j.
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClient.java b15b024
> lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java 14a0690
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java 61e16f7
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java b4e0552
> lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java c68dd12
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/BaseSparkAlgo.java 86cab38
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/ColumnFeatureFunction.java d75efc0
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/HiveTableRDD.java 4960e1e
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/SparkMLDriver.java 21ed87d
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/TableTrainingSpec.java 897aacb
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/HiveMLUDF.java 60a4008
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLRunner.java e5ec272
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLTask.java 2867b90
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/ModelLoader.java c0e7953
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/TableTestingSpec.java 34b2a3f
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceImpl.java de9c711
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 77a6c40
> lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java fc4164f
> lens-ml-lib/src/test/java/org/apache/lens/ml/ExampleUtils.java 9fe1ea0
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 7f6413b
> lens-regression/pom.xml 66ddbb0
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java ad67d7d
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java 7fd3c47
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 5d58ef2
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java 2aecbfd
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java ca59e3e
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java abcea2b
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 5db4fa6
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 595ef67
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java c3fe8eb
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java 5b6ec3b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 71a37f0
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 3e7de17
>
> Diff: https://reviews.apache.org/r/36631/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.898s]
> [INFO] Lens .............................................. SUCCESS [2.914s]
> [INFO] Lens API .......................................... SUCCESS [22.436s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.394s]
> [INFO] Lens Cube ......................................... SUCCESS [4:29.612s]
> [INFO] Lens DB storage ................................... SUCCESS [20.075s]
> [INFO] Lens Query Library ................................ SUCCESS [15.299s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.536s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.498s]
> [INFO] Lens Server ....................................... SUCCESS [5:43.152s]
> [INFO] Lens client ....................................... SUCCESS [34.075s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.200s]
> [INFO] Lens Examples ..................................... SUCCESS [8.672s]
> [INFO] Lens Distribution ................................. SUCCESS [7.976s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.728s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.667s]
> [INFO] Lens Regression ................................... SUCCESS [9.617s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:54.592s
> [INFO] Finished at: Tue Jul 21 07:47:47 UTC 2015
> [INFO] Final Memory: 176M/1297M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36631: LENS-679 : Use slf4j in api, regression,
ml and client modules
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36631/#review92386
-----------------------------------------------------------
lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java (line 233)
<https://reviews.apache.org/r/36631/#comment146529>
Seems missing argument palceholder **{}**.
lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java (line 371)
<https://reviews.apache.org/r/36631/#comment146530>
Seems missing argument palceholder **{}**.
lens-ml-lib/src/test/java/org/apache/lens/ml/ExampleUtils.java (line 98)
<https://reviews.apache.org/r/36631/#comment146531>
Can we rewrite the log with argument placeholders **{}**?
- Raju Bairishetti
On July 21, 2015, 8:03 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36631/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 8:03 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-679
> https://issues.apache.org/jira/browse/LENS-679
>
>
> Repository: lens
>
>
> Description
> -------
>
> Checked for log4j and commons logging in the modules through git grep and updated all usage to Slf4j.
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClient.java b15b024
> lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java 14a0690
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java 61e16f7
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java b4e0552
> lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java c68dd12
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/BaseSparkAlgo.java 86cab38
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/ColumnFeatureFunction.java d75efc0
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/HiveTableRDD.java 4960e1e
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/SparkMLDriver.java 21ed87d
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/TableTrainingSpec.java 897aacb
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/HiveMLUDF.java 60a4008
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLRunner.java e5ec272
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLTask.java 2867b90
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/ModelLoader.java c0e7953
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/TableTestingSpec.java 34b2a3f
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceImpl.java de9c711
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 77a6c40
> lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java fc4164f
> lens-ml-lib/src/test/java/org/apache/lens/ml/ExampleUtils.java 9fe1ea0
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 7f6413b
> lens-regression/pom.xml 66ddbb0
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java ad67d7d
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java 7fd3c47
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 5d58ef2
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java 2aecbfd
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java ca59e3e
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java abcea2b
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 5db4fa6
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 595ef67
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java c3fe8eb
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java 5b6ec3b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 71a37f0
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 3e7de17
>
> Diff: https://reviews.apache.org/r/36631/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.898s]
> [INFO] Lens .............................................. SUCCESS [2.914s]
> [INFO] Lens API .......................................... SUCCESS [22.436s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.394s]
> [INFO] Lens Cube ......................................... SUCCESS [4:29.612s]
> [INFO] Lens DB storage ................................... SUCCESS [20.075s]
> [INFO] Lens Query Library ................................ SUCCESS [15.299s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.536s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.498s]
> [INFO] Lens Server ....................................... SUCCESS [5:43.152s]
> [INFO] Lens client ....................................... SUCCESS [34.075s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.200s]
> [INFO] Lens Examples ..................................... SUCCESS [8.672s]
> [INFO] Lens Distribution ................................. SUCCESS [7.976s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.728s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.667s]
> [INFO] Lens Regression ................................... SUCCESS [9.617s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:54.592s
> [INFO] Finished at: Tue Jul 21 07:47:47 UTC 2015
> [INFO] Final Memory: 176M/1297M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36631: LENS-679 : Use slf4j in api, regression,
ml and client modules
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36631/
-----------------------------------------------------------
(Updated July 21, 2015, 11:41 a.m.)
Review request for lens.
Changes
-------
Updated to master and checkstyle fixed
Bugs: LENS-679
https://issues.apache.org/jira/browse/LENS-679
Repository: lens
Description
-------
Checked for log4j and commons logging in the modules through git grep and updated all usage to Slf4j.
Diffs (updated)
-----
lens-client/src/main/java/org/apache/lens/client/LensClient.java d7df1ba
lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java 14a0690
lens-client/src/main/java/org/apache/lens/client/LensConnection.java 61e16f7
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java dba13ca
lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java c68dd12
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/BaseSparkAlgo.java 86cab38
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/ColumnFeatureFunction.java d75efc0
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/HiveTableRDD.java 4960e1e
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/SparkMLDriver.java 21ed87d
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/TableTrainingSpec.java 897aacb
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/HiveMLUDF.java 60a4008
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLRunner.java e5ec272
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLTask.java 2867b90
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/ModelLoader.java c0e7953
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/TableTestingSpec.java 34b2a3f
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceImpl.java de9c711
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 77a6c40
lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java fc4164f
lens-ml-lib/src/test/java/org/apache/lens/ml/ExampleUtils.java 9fe1ea0
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 7f6413b
lens-regression/pom.xml 66ddbb0
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java ad67d7d
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java 7fd3c47
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 5d58ef2
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java 2aecbfd
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java ca59e3e
lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java abcea2b
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 5db4fa6
lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 595ef67
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java c3fe8eb
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java 5b6ec3b
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 71a37f0
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 3e7de17
Diff: https://reviews.apache.org/r/36631/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.898s]
[INFO] Lens .............................................. SUCCESS [2.914s]
[INFO] Lens API .......................................... SUCCESS [22.436s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.394s]
[INFO] Lens Cube ......................................... SUCCESS [4:29.612s]
[INFO] Lens DB storage ................................... SUCCESS [20.075s]
[INFO] Lens Query Library ................................ SUCCESS [15.299s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:48.536s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.498s]
[INFO] Lens Server ....................................... SUCCESS [5:43.152s]
[INFO] Lens client ....................................... SUCCESS [34.075s]
[INFO] Lens CLI .......................................... SUCCESS [2:37.200s]
[INFO] Lens Examples ..................................... SUCCESS [8.672s]
[INFO] Lens Distribution ................................. SUCCESS [7.976s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.728s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.667s]
[INFO] Lens Regression ................................... SUCCESS [9.617s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:54.592s
[INFO] Finished at: Tue Jul 21 07:47:47 UTC 2015
[INFO] Final Memory: 176M/1297M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 36631: LENS-679 : Use slf4j in api, regression,
ml and client modules
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36631/#review92389
-----------------------------------------------------------
Ship it!
Ship It!
- Raju Bairishetti
On July 21, 2015, 9:32 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36631/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 9:32 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-679
> https://issues.apache.org/jira/browse/LENS-679
>
>
> Repository: lens
>
>
> Description
> -------
>
> Checked for log4j and commons logging in the modules through git grep and updated all usage to Slf4j.
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClient.java d7df1ba
> lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java 14a0690
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java 61e16f7
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java dba13ca
> lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java c68dd12
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/BaseSparkAlgo.java 86cab38
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/ColumnFeatureFunction.java d75efc0
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/HiveTableRDD.java 4960e1e
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/SparkMLDriver.java 21ed87d
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/TableTrainingSpec.java 897aacb
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/HiveMLUDF.java 60a4008
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLRunner.java e5ec272
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLTask.java 2867b90
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/ModelLoader.java c0e7953
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/TableTestingSpec.java 34b2a3f
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceImpl.java de9c711
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 77a6c40
> lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java fc4164f
> lens-ml-lib/src/test/java/org/apache/lens/ml/ExampleUtils.java 9fe1ea0
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 7f6413b
> lens-regression/pom.xml 66ddbb0
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java ad67d7d
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java 7fd3c47
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 5d58ef2
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java 2aecbfd
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java ca59e3e
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java abcea2b
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 5db4fa6
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 595ef67
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java c3fe8eb
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java 5b6ec3b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 71a37f0
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 3e7de17
>
> Diff: https://reviews.apache.org/r/36631/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.898s]
> [INFO] Lens .............................................. SUCCESS [2.914s]
> [INFO] Lens API .......................................... SUCCESS [22.436s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.394s]
> [INFO] Lens Cube ......................................... SUCCESS [4:29.612s]
> [INFO] Lens DB storage ................................... SUCCESS [20.075s]
> [INFO] Lens Query Library ................................ SUCCESS [15.299s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.536s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.498s]
> [INFO] Lens Server ....................................... SUCCESS [5:43.152s]
> [INFO] Lens client ....................................... SUCCESS [34.075s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.200s]
> [INFO] Lens Examples ..................................... SUCCESS [8.672s]
> [INFO] Lens Distribution ................................. SUCCESS [7.976s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.728s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.667s]
> [INFO] Lens Regression ................................... SUCCESS [9.617s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:54.592s
> [INFO] Finished at: Tue Jul 21 07:47:47 UTC 2015
> [INFO] Final Memory: 176M/1297M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36631: LENS-679 : Use slf4j in api, regression,
ml and client modules
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36631/
-----------------------------------------------------------
(Updated July 21, 2015, 9:32 a.m.)
Review request for lens.
Changes
-------
Review comments fixed
Bugs: LENS-679
https://issues.apache.org/jira/browse/LENS-679
Repository: lens
Description
-------
Checked for log4j and commons logging in the modules through git grep and updated all usage to Slf4j.
Diffs (updated)
-----
lens-client/src/main/java/org/apache/lens/client/LensClient.java d7df1ba
lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java 14a0690
lens-client/src/main/java/org/apache/lens/client/LensConnection.java 61e16f7
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java dba13ca
lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java c68dd12
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/BaseSparkAlgo.java 86cab38
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/ColumnFeatureFunction.java d75efc0
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/HiveTableRDD.java 4960e1e
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/SparkMLDriver.java 21ed87d
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/TableTrainingSpec.java 897aacb
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/HiveMLUDF.java 60a4008
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLRunner.java e5ec272
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLTask.java 2867b90
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/ModelLoader.java c0e7953
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/TableTestingSpec.java 34b2a3f
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceImpl.java de9c711
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 77a6c40
lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java fc4164f
lens-ml-lib/src/test/java/org/apache/lens/ml/ExampleUtils.java 9fe1ea0
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 7f6413b
lens-regression/pom.xml 66ddbb0
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java ad67d7d
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java 7fd3c47
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 5d58ef2
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java 2aecbfd
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java ca59e3e
lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java abcea2b
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 5db4fa6
lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 595ef67
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java c3fe8eb
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java 5b6ec3b
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 71a37f0
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 3e7de17
Diff: https://reviews.apache.org/r/36631/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.898s]
[INFO] Lens .............................................. SUCCESS [2.914s]
[INFO] Lens API .......................................... SUCCESS [22.436s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.394s]
[INFO] Lens Cube ......................................... SUCCESS [4:29.612s]
[INFO] Lens DB storage ................................... SUCCESS [20.075s]
[INFO] Lens Query Library ................................ SUCCESS [15.299s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:48.536s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.498s]
[INFO] Lens Server ....................................... SUCCESS [5:43.152s]
[INFO] Lens client ....................................... SUCCESS [34.075s]
[INFO] Lens CLI .......................................... SUCCESS [2:37.200s]
[INFO] Lens Examples ..................................... SUCCESS [8.672s]
[INFO] Lens Distribution ................................. SUCCESS [7.976s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.728s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.667s]
[INFO] Lens Regression ................................... SUCCESS [9.617s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:54.592s
[INFO] Finished at: Tue Jul 21 07:47:47 UTC 2015
[INFO] Final Memory: 176M/1297M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu