You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shant Hovsepian (Code Review)" <ge...@cloudera.org> on 2020/11/24 03:12:03 UTC
[Impala-ASF-CR] Fix for run-time crash in scheduler-benchmark
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16778
Change subject: Fix for run-time crash in scheduler-benchmark
......................................................................
Fix for run-time crash in scheduler-benchmark
Updated scheduler-benchmark's main() to use the newer impala
initialization methods.
Before this change the benchmark would compile properly but would crash
at run-time.
Testing:
* built and ran in debug and release mode.
Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
---
M be/src/benchmarks/scheduler-benchmark.cc
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/16778/1
--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Tim Armstrong, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16778
to look at the new patch set (#2).
Change subject: Fix for startup crash in scheduler-benchmark.
......................................................................
Fix for startup crash in scheduler-benchmark.
Updated scheduler-benchmark's main() to use the newer
impala::InitCommonRuntime() initialization methods.
Before this change the benchmark would compile properly but crash
when run.
Testing:
* built and ran in debug and release mode.
Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
---
M be/src/benchmarks/scheduler-benchmark.cc
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/16778/2
--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16778 )
Change subject: Fix for startup crash in scheduler-benchmark.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6716/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Nov 2020 21:19:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix for run-time crash in scheduler-benchmark
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16778 )
Change subject: Fix for run-time crash in scheduler-benchmark
......................................................................
Patch Set 1:
Small fix to get the scheduler benchmark running again.
--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Nov 2020 03:14:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix for run-time crash in scheduler-benchmark
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16778 )
Change subject: Fix for run-time crash in scheduler-benchmark
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7720/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Nov 2020 03:33:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16778 )
Change subject: Fix for startup crash in scheduler-benchmark.
......................................................................
Fix for startup crash in scheduler-benchmark.
Updated scheduler-benchmark's main() to use the newer
impala::InitCommonRuntime() initialization methods.
Before this change the benchmark would compile properly but crash
when run.
Testing:
* built and ran in debug and release mode.
Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Reviewed-on: http://gerrit.cloudera.org:8080/16778
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/benchmarks/scheduler-benchmark.cc
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 3
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16778 )
Change subject: Fix for startup crash in scheduler-benchmark.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Nov 2020 02:49:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16778 )
Change subject: Fix for startup crash in scheduler-benchmark.
......................................................................
Patch Set 2: Code-Review+2
This looks good to me.
If you are looking into scheduler performance, one related JIRA is IMPALA-9221.
--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Nov 2020 16:34:48 +0000
Gerrit-HasComments: No