You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2023/02/08 14:28:21 UTC
[GitHub] [shardingsphere] yx9o opened a new pull request, #24065: RALStatement inheritance structure optimization.
yx9o opened a new pull request, #24065:
URL: https://github.com/apache/shardingsphere/pull/24065
For #23955 .
Changes proposed in this pull request:
- GlobalRuleRALStatement inheritance structure adjustment.
- ScalingRALStatement inheritance structure adjustment.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24065: RALStatement inheritance structure optimization.
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24065:
URL: https://github.com/apache/shardingsphere/pull/24065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24065: RALStatement inheritance structure optimization.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24065:
URL: https://github.com/apache/shardingsphere/pull/24065#issuecomment-1422728857
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24065?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24065](https://codecov.io/gh/apache/shardingsphere/pull/24065?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4cdf61) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ab9547b32132d5c3918c0879e87b749a486af686?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab9547b) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head f4cdf61 differs from pull request most recent head 9ce94c0. Consider uploading reports for the commit 9ce94c0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24065 +/- ##
=========================================
Coverage 50.15% 50.15%
Complexity 1561 1561
=========================================
Files 3242 3240 -2
Lines 53152 53150 -2
Branches 9783 9783
=========================================
Hits 26659 26659
+ Misses 24151 24149 -2
Partials 2342 2342
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ment/ral/scaling/UpdatableScalingRALStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/24065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9yYWwvc2NhbGluZy9VcGRhdGFibGVTY2FsaW5nUkFMU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org