You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:58:11 UTC
[GitHub] [incubator-nuttx-apps] SPRESENSE opened a new pull request #345: Fix build errors
SPRESENSE opened a new pull request #345:
URL: https://github.com/apache/incubator-nuttx-apps/pull/345
## Summary
- Fix application build mistakes
- Update hash tool
- Fix typos
## Impact
Whole apps builds
## Testing
Update Make.dep file by config changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea merged pull request #345: Fix build errors
Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #345:
URL: https://github.com/apache/incubator-nuttx-apps/pull/345
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #345: Fix build errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #345:
URL: https://github.com/apache/incubator-nuttx-apps/pull/345#discussion_r461401263
##########
File path: Application.mk
##########
@@ -88,6 +88,7 @@ ifneq ($(BUILD_MODULE),y)
endif
ROOTDEPPATH += --dep-path .
Review comment:
DEPPATH is used consitently in nuttx folder. Why not convert all ROOTDEPPATH to DEPPATH?
##########
File path: Application.mk
##########
@@ -88,6 +88,7 @@ ifneq ($(BUILD_MODULE),y)
endif
ROOTDEPPATH += --dep-path .
Review comment:
Yes, it's better to unify into DEPPATH, thanks.
##########
File path: system/spi/Kconfig
##########
@@ -15,7 +15,7 @@ if SYSTEM_SPITOOL
config SPITOOL_PROGNAME
string "Program name"
- default "hello"
+ default "spi"
Review comment:
need remove CONFIG_SPITOOL_PROGNAME from these defconfig:
boards/arm/s32k1xx/rddrone-uavcan144/configs/nsh/defconfig
boards/arm/s32k1xx/rddrone-uavcan144/configs/nshdebug/defconfig
boards/arm/s32k1xx/rddrone-uavcan146/configs/nsh/defconfig
boards/arm/s32k1xx/rddrone-uavcan146/configs/nshdebug/defconfig
otherwise the build will break:
https://github.com/apache/incubator-nuttx-apps/pull/345/checks?check_run_id=917971406
##########
File path: system/spi/Kconfig
##########
@@ -15,7 +15,7 @@ if SYSTEM_SPITOOL
config SPITOOL_PROGNAME
string "Program name"
- default "hello"
+ default "spi"
Review comment:
Only commiter can restart the check, I will do it once apache/incubator-nuttx#1477 get merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #345: Fix build errors
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #345:
URL: https://github.com/apache/incubator-nuttx-apps/pull/345#issuecomment-665477017
@SPRESENSE Please add a commit message like you did on the other commits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] SPRESENSE commented on a change in pull request #345: Fix build errors
Posted by GitBox <gi...@apache.org>.
SPRESENSE commented on a change in pull request #345:
URL: https://github.com/apache/incubator-nuttx-apps/pull/345#discussion_r461424024
##########
File path: Application.mk
##########
@@ -88,6 +88,7 @@ ifneq ($(BUILD_MODULE),y)
endif
ROOTDEPPATH += --dep-path .
Review comment:
Because I don't know why both ROOTDEPPATH and DEPPATH are existed. So just add it conveniently.
I'll be merged to DEPPATH in some apps if you think it is better.
##########
File path: system/spi/Kconfig
##########
@@ -15,7 +15,7 @@ if SYSTEM_SPITOOL
config SPITOOL_PROGNAME
string "Program name"
- default "hello"
+ default "spi"
Review comment:
uploaded apache/incubator-nuttx#1477.
Can I build check again after that is merged?
##########
File path: system/spi/Kconfig
##########
@@ -15,7 +15,7 @@ if SYSTEM_SPITOOL
config SPITOOL_PROGNAME
string "Program name"
- default "hello"
+ default "spi"
Review comment:
Thanks.
##########
File path: Application.mk
##########
@@ -88,6 +88,7 @@ ifneq ($(BUILD_MODULE),y)
endif
ROOTDEPPATH += --dep-path .
Review comment:
I added a new commit that unify into DEPPATH.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] SPRESENSE commented on pull request #345: Fix build errors
Posted by GitBox <gi...@apache.org>.
SPRESENSE commented on pull request #345:
URL: https://github.com/apache/incubator-nuttx-apps/pull/345#issuecomment-665505997
@jerpelea Sorry, I update commit message. Please check again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #345: Fix build errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #345:
URL: https://github.com/apache/incubator-nuttx-apps/pull/345#issuecomment-665452948
LGTM, I will merge the patch once the check pass,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea edited a comment on pull request #345: Fix build errors
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #345:
URL: https://github.com/apache/incubator-nuttx-apps/pull/345#issuecomment-665477017
@SPRESENSE Please add a commit message on the last commit like you did on the other commits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org