You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2025/01/29 02:49:03 UTC

(spark) branch master updated: [SPARK-50909][PYTHON][FOLLOWUP] Disable segfault tests in pypy

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 8dbf1dd82bfb [SPARK-50909][PYTHON][FOLLOWUP] Disable segfault tests in pypy
8dbf1dd82bfb is described below

commit 8dbf1dd82bfb36bf4b43fa0cf082ce8b02b826b5
Author: Takuya Ueshin <ue...@databricks.com>
AuthorDate: Tue Jan 28 18:48:53 2025 -0800

    [SPARK-50909][PYTHON][FOLLOWUP] Disable segfault tests in pypy
    
    ### What changes were proposed in this pull request?
    
    Disable segfault tests in `pypy`, same as in `test_udf`.
    
    ### Why are the changes needed?
    
    In pypy environment, segfault doesn't happen.
    
    - https://github.com/apache/spark/pull/49592#pullrequestreview-2577075949
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    The existing tests should pass.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No.
    
    Closes #49720 from ueshin/issues/SPARK-50909/pypy.
    
    Authored-by: Takuya Ueshin <ue...@databricks.com>
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 python/pyspark/sql/tests/test_python_datasource.py | 4 ++++
 python/pyspark/sql/tests/test_udtf.py              | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/python/pyspark/sql/tests/test_python_datasource.py b/python/pyspark/sql/tests/test_python_datasource.py
index 9b132f5d693f..34299bdb7740 100644
--- a/python/pyspark/sql/tests/test_python_datasource.py
+++ b/python/pyspark/sql/tests/test_python_datasource.py
@@ -15,6 +15,7 @@
 # limitations under the License.
 #
 import os
+import platform
 import tempfile
 import unittest
 from typing import Callable, Union
@@ -508,6 +509,9 @@ class BasePythonDataSourceTestsMixin:
         ):
             df.write.format("test").mode("append").saveAsTable("test_table")
 
+    @unittest.skipIf(
+        "pypy" in platform.python_implementation().lower(), "cannot run in environment pypy"
+    )
     def test_data_source_segfault(self):
         import ctypes
 
diff --git a/python/pyspark/sql/tests/test_udtf.py b/python/pyspark/sql/tests/test_udtf.py
index ef029adfb476..95a81236fbf5 100644
--- a/python/pyspark/sql/tests/test_udtf.py
+++ b/python/pyspark/sql/tests/test_udtf.py
@@ -15,6 +15,7 @@
 # limitations under the License.
 #
 import os
+import platform
 import shutil
 import tempfile
 import unittest
@@ -2761,6 +2762,9 @@ class BaseUDTFTestsMixin:
         res = self.spark.sql("select i, to_json(v['v1']) from test_udtf_struct(8)")
         assertDataFrameEqual(res, [Row(i=n, s=f'{{"a":"{chr(99 + n)}"}}') for n in range(8)])
 
+    @unittest.skipIf(
+        "pypy" in platform.python_implementation().lower(), "cannot run in environment pypy"
+    )
     def test_udtf_segfault(self):
         for enabled, expected in [
             (True, "Segmentation fault"),


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org